Improved: Implement Type safe Config in OFBiz#1285
Draft
nmalin wants to merge 6 commits into
Draft
Conversation
jacopoc
reviewed
May 27, 2026
| * <ul> | ||
| * <li>Possess a <code>public static final String ELEMENT_NAME</code> containing the name of the XML element to which the class refers to</li> | ||
| * <li>If needed a <code>public static final String ELEMENT_FIELD_ID_NAME</code> containing the attribut name of the XML element | ||
| * that identify as unique the element. Else the <code>name</code> string will be used</></></li> |
Contributor
There was a problem hiding this comment.
The above line is causing a javadoc error (malformed HTML) due to the presence of </></>
Contributor
Author
There was a problem hiding this comment.
Yes right jacopo, I only run ./gradlew check on local and not javdoc 😅 I will fix that
jacopoc
reviewed
May 27, 2026
| * <li>If needed a <code>public static final String ELEMENT_FIELD_ID_NAME</code> containing the attribut name of the XML element | ||
| * that identify as unique the element. Else the <code>name</code> string will be used</></></li> | ||
| * <li>Have a first constructor with an <code>Element</code> and a <code>String</code> as parameters</li> | ||
| * <li>Have a second constructor with a <code>Map<<span/>String, Object></code> and a <code>String</code> as parameters</li> |
Contributor
There was a problem hiding this comment.
The above line is causing some javadoc errors (self-closing element not allowed, semicolon missing, etc...).
Contributor
Author
There was a problem hiding this comment.
I fixed it, thanks for this spot !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.