drives/input: support ST7123 touchscreen controller - #19674
Open
fdcavalcanti wants to merge 2 commits into
Open
Conversation
fdcavalcanti
requested review from
acassis,
raiden00pl and
xiaoxiang781216
as code owners
August 3, 2026 18:09
Contributor
|
Hi @fdcavalcanti please fix this CI issue: |
fdcavalcanti
force-pushed
the
feature/st7123-touch
branch
from
August 3, 2026 23:37
a4f749f to
35380f0
Compare
eren-terzioglu
previously approved these changes
Aug 4, 2026
Add support for ST7123 touchscreen controller (I2C only). It requires board level init to register a callback, as polling mode is not supported. Signed-off-by: Filipe Cavalcanti <filipe.cavalcanti@espressif.com>
Adds documentation to input and touchscreen controller files, regarding support for ST7123 IC. Signed-off-by: Filipe Cavalcanti <filipe.cavalcanti@espressif.com>
Contributor
Author
|
@xiaoxiang781216 all fixes applied, thanks for the review! |
fdcavalcanti
force-pushed
the
feature/st7123-touch
branch
from
August 4, 2026 12:51
35380f0 to
e06c1a2
Compare
acassis
approved these changes
Aug 4, 2026
|
|
||
| /* Registered device instance used by st7123_interrupt_callback(). */ | ||
|
|
||
| static FAR struct st7123_dev_t *g_st7123_dev; |
Contributor
There was a problem hiding this comment.
how to support the multiple instances? let's remove this global variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for ST7123 touchscreen controller (I2C only).
It requires board level init to register a callback, as polling mode is not supported.
Documentation/components/drivers/character/input/st7123.rstDatasheet: link
AI Disclaimer
AI agents used for code documentation only.
Impact
CONFIG_INPUT_ST7123(default off); no effect unless selectedst7123_register()/st7123_interrupt_callback();polling is not supportedstruct touch_sample_s;multi-touch needs a buffer sized withSIZEOF_TOUCH_SAMPLE_S(n)Testing
Tested on
esp32p4-tab5.Device is working as expected. Here's the output from
tc_main(touchscreen example):Touching corner:
Touch middle: