{bp-19583} boards/sim: drop unused FSUTILS_PASSWD from sim defconfigs - #19672
Merged
Conversation
jerpelea
requested review from
Donny9,
GUIDINGLI,
Ouss4,
acassis,
anchao,
btashton,
davids5,
eren-terzioglu,
fdcavalcanti,
gustavonihei,
hartmannathan,
linguini1,
liuguo09,
lupyuen,
michallenc,
pussuw,
raiden00pl,
simbit18,
tmedicci,
xiaoxiang781216 and
yamt
as code owners
August 3, 2026 14:43
Contributor
Author
|
PLEASE DO NOT MERGE UNLESS CI PASSES! |
cederom
approved these changes
Aug 3, 2026
acassis
approved these changes
Aug 3, 2026
cederom
requested changes
Aug 3, 2026
github-actions
Bot
added
Area: Build system
Size: XL
Add config to use Dropbear in sim environment. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Describe how to build and use the Dropbear SSH server configuration on the simulator, including host TAP network setup, user creation and the volatile /tmp host key/passwd caveat. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Add a board configuration that enables the Dropbear SSH server on the ESP32-C3 DevKit with Wi-Fi networking and the required crypto support. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Describe how to enable and use the Dropbear SSH server on the ESP32-C3 DevKit, including Wi-Fi, host key, and login configuration. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Dropbear's NSH PTY session reaps the child task with waitpid() and needs CONFIG_SCHED_CHILD_STATUS, which depends on SCHED_HAVE_PARENT. The netutils/dropbear Kconfig now depends on SCHED_HAVE_PARENT and selects SCHED_CHILD_STATUS (apache/nuttx-apps#3648); set SCHED_HAVE_PARENT here so the dropbear defconfig stays consistent and the session no longer fails with ECHILD after authentication. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Dropbear's NSH PTY session reaps the child task with waitpid() and needs
CONFIG_SCHED_CHILD_STATUS (which depends on SCHED_HAVE_PARENT). Without it
the session fails with ECHILD right after authentication
("NSH session wait failed: Unknown error 10").
netutils/dropbear now "depends on SCHED_CHILD_STATUS" per the project's
depends-on-over-select policy (apache/nuttx-apps#3648), so enable it in the
sim and esp32c3-devkit Dropbear defconfigs (SCHED_HAVE_PARENT is already
enabled there).
Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Drop the esp32c3-devkit:dropbear defconfig and its documentation. The companion apps#3636 (Dropbear over /dev/crypto for this board) is stuck on an unrelated Espressif CI dependency issue, and the port is moving to different hardware. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Add a LittleFS mount option for the on-board N25Q QSPI flash, mirroring the existing NXFFS/LittleFS toggle already used by the sibling stm32_w25q.c driver. Needed because NXFFS does not support rename(), which the companion Dropbear config depends on. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Add a stm32f746g-disco:dropbear config for NSH over SSH on the board's Ethernet, with the password file and Dropbear host key persisted on QSPI flash (LittleFS) instead of RAM. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
Document the new stm32f746g-disco:dropbear configuration, mirroring the existing esp32c3-devkit Dropbear documentation. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
apache/nuttx-apps#3636 depends on it; without it NETUTILS_DROPBEAR silently disables on reconfigure. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
apache/nuttx-apps#3636 depends on it; without it NETUTILS_DROPBEAR silently disables on reconfigure. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
merge conflict introduced in master by apache#19422 which changed the spaces without a separate commit Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
Add standalone host PBKDF2-HMAC-SHA256 mkpasswd, board_romfs_mkpasswd.sh, and promptpasswd.sh with confirm-password support. Integrate ROMFS passwd generation in Board.mk and CMake. Drop TEA key checks from passwd_keys.mk. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Migrate moxa:nsh from fixed telnet password to build-time ROMFS /etc/passwd with PBKDF2-HMAC-SHA256 and cryptodev. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Document PBKDF2-HMAC-SHA256 ROMFS passwd generation and update board Kconfig help text accordingly. Set the documented sim/login CI credential in GitHub Actions. Enable CONFIG_CODECS_BASE64 and CONFIG_NETUTILS_CODECS on sim:dropbear for link compatibility with dropbear's bundled libtomcrypt. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Enable BOARD_ETC_ROMFS_PASSWD_ENABLE and software cryptodev options on all sim configs with CONFIG_NSH_CONSOLE_LOGIN so PBKDF2 login works on NuttX 13.0+. Fixes apache#19573. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
BOARD_ETC_ROMFS_PASSWD_ENABLE now depends on FSUTILS_PASSWD and a cryptodev backend so PBKDF2 passwd autogen cannot be enabled without the runtime login stack. Fixes apache#19573. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Remove CONFIG_FSUTILS_PASSWD from 31 sim configs that do not use NSH login or other passwd features. These configs lacked a cryptodev backend required by FSUTILS_PASSWD after the PBKDF2 Kconfig tightening, causing olddefconfig normalization failures in CI. Fixes apache#19573 Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Add application-level documentation for the Dropbear SSH server port, covering prerequisites, configuration options, usage and troubleshooting. Signed-off-by: Felipe Moura <moura.fmo@gmail.com>
nuttx-apps#3557 switches NETUTILS_DROPBEAR to depend on CRYPTO and CRYPTO_RANDOM_POOL instead of selecting them. sim/dropbear must enable CONFIG_CRYPTO and CONFIG_CRYPTO_RANDOM_POOL explicitly so olddefconfig and CI normalize keep dropbear and FSUTILS_PASSWD enabled. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
… defconfig nuttx-apps#3557 switches FSUTILS_PASSWD and NETUTILS_DROPBEAR to depend on CRYPTO, CRYPTO_RANDOM_POOL, NETUTILS_CODECS and CODECS_BASE64 instead of selecting them. stm32f746g-disco/dropbear must enable these explicitly so olddefconfig/CI normalize keeps dropbear and FSUTILS_PASSWD enabled. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Contributor
Author
|
dc75989 is not signed and CI error related to it can be ignored |
Contributor
|
Maybe you could git rebase -i that commit and edit message during git commit --amend @jerpelea ? There are too many commits bundled here... or we just ignore that? |
Contributor
Author
it will not match the original commit so ...NO! |
cederom
approved these changes
Aug 5, 2026
Contributor
|
roger that! how this even hot merged to the upstream? o_O |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove CONFIG_FSUTILS_PASSWD from 31 sim configs that do not use NSH login or other passwd features. These configs lacked a cryptodev backend required by FSUTILS_PASSWD after the PBKDF2 Kconfig tightening, causing olddefconfig normalization failures in CI.
includes
revert f5291a8
#19321
#19167
#19405
#19062
#19474
#19481
#19490
#19483
#19492
#19209
#19576
#19583
#19190
#19498
Impact
RELEASE
Testing
CI