include/fcntl.h: remove O_RDOK/O_WROK aliases#19231
Merged
Merged
Conversation
O_RDOK and O_WROK are non-standard aliases for O_RDONLY and O_WRONLY respectively. Having two names for the same flag creates confusion, especially when aligning the flag values with Linux. Remove the aliases and replace all uses with the standard O_RDONLY/O_WRONLY. No functional change — O_RDOK was defined as O_RDONLY and O_WROK as O_WRONLY, so the replacement is a pure text substitution. Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
requested review from
Donny9,
GUIDINGLI,
Ouss4,
acassis,
anchao,
gustavonihei,
hartmannathan,
jerpelea,
michallenc,
pkarashchenko,
pussuw and
yamt
as code owners
github-actions
Bot
added
Area: Drivers
|
Donny9
approved these changes
Jun 28, 2026
acassis
approved these changes
Jun 28, 2026
Contributor
|
Hi @xiaoxiang781216 @acassis, This PR was merged too quickly; there are many broken jobs. |
Contributor
|
@simbit18 you are right, I thought since apache/nuttx-apps#3566 was merged it was safe to merge this change, but seems like it was not! |
Contributor
Author
fix here: ci error is fixed by apache/nuttx-apps#3568. @simbit18 @acassis . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
O_RDOKandO_WROKare non-standard aliases forO_RDONLYandO_WRONLYrespectively. Having two names for the same flag creates confusion, especially when aligning the flag values with Linux. This PR removes the aliases frominclude/fcntl.hand replaces all in-tree uses with the standardO_RDONLY/O_WRONLY.Impact
No functional change.
O_RDOKwas defined asO_RDONLYandO_WROKasO_WRONLY, so the replacement is a pure text substitution that preserves existing behavior while using the standard POSIX flag names.A companion change for the apps repository (replacing the remaining
O_RDOKusages there) is submitted separately as apache/nuttx-apps#3566.Testing
tools/checkpatch.sh -c -u -m -g(commit mode, same as CI) passes with no errors.git grep 'O_RDOK\|O_WROK'confirms no remaining references in the tree.Note
need merge apache/nuttx-apps#3566 first