libc/unistd: add getgroups()#19182
Open
xiaoxiang781216 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Area: OS Components
|
xiaoxiang781216
force-pushed
the
upstream-getgroups
branch
2 times, most recently
from
1d59240 to
d4db122
Compare
Add getgroups() to the C library. NuttX has no supplementary group IDs, so it reports a single group, the effective group ID, and follows POSIX for the gidsetsize == 0 and short-buffer (EINVAL) cases. Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
upstream-getgroups
branch
from
d4db122 to
7754cfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
getgroups()to the C library. POSIX requiresgetgroups()toreturn the supplementary group IDs of the calling process. NuttX has no
notion of supplementary group IDs, so the calling process is treated as
belonging to a single group: its effective group ID.
Behavior:
grouplist, per POSIX.
and return 1.
It is declared in <unistd.h> and always built, since it only depends on
the public getegid().
Impact
New public POSIX API. No change to existing behavior or build for code
that does not call getgroups(). Helps porting third-party software that
expects getgroups() to be available.
Testing
Built the sim:nsh configuration on Linux (x86_64, GCC) with
CONFIG_LIBC_GROUP_FILE both enabled and disabled. checkpatch.sh passes
on the changed files.