fs/littlefs: Enforce open permissions and set create ownership#19166
Open
Abhishekmishra2808 wants to merge 1 commit into
Open
fs/littlefs: Enforce open permissions and set create ownership#19166Abhishekmishra2808 wants to merge 1 commit into
Abhishekmishra2808 wants to merge 1 commit into
Conversation
Abhishekmishra2808
requested review from
Donny9,
Ouss4 and
xiaoxiang781216
as code owners
github-actions
Bot
added
Area: File System
Abhishekmishra2808
force-pushed
the
vfs/littlefs-permissions
branch
from
5ea99b9 to
fdc0611
Compare
Contributor
|
How was this tested? |
Contributor
Author
@linguini1, Please review the updated PR description. |
Contributor
Author
|
@acassis PTAL |
acassis
requested changes
Jun 19, 2026
acassis
left a comment
acassis
left a comment
Contributor
There was a problem hiding this comment.
@Abhishekmishra2808 please update the LittleFS documentation as well
linguini1
reviewed
Jun 19, 2026
linguini1
requested changes
Jun 19, 2026
linguini1
left a comment
linguini1
left a comment
Contributor
There was a problem hiding this comment.
This seems to do more than just add permission checking.
Abhishekmishra2808
force-pushed
the
vfs/littlefs-permissions
branch
from
fdc0611 to
bde985c
Compare
Contributor
Author
|
My bad, I forgot to do a rebase. These edits are totally unintentional and came from not rebasing onto master. Now I have fixed these. |
|
Abhishekmishra2808
force-pushed
the
vfs/littlefs-permissions
branch
from
bde985c to
d0121c2
Compare
github-actions
Bot
added
Area: Documentation
Abhishekmishra2808
force-pushed
the
vfs/littlefs-permissions
branch
from
d0121c2 to
80cf4cd
Compare
Contributor
Author
|
@acassis, I have added the docs as well. Please check. |
acassis
previously approved these changes
Jun 19, 2026
Abhishekmishra2808
force-pushed
the
vfs/littlefs-permissions
branch
from
80cf4cd to
05b8975
Compare
linguini1
previously approved these changes
Jun 20, 2026
acassis
previously approved these changes
Jun 20, 2026
Abhishekmishra2808
force-pushed
the
vfs/littlefs-permissions
branch
from
05b8975 to
519a9e2
Compare
Check open access against file mode and owner via fs_checkmode(), verify parent directory permissions on create, and assign creator uid/gid to newly created files. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
force-pushed
the
vfs/littlefs-permissions
branch
from
519a9e2 to
39f29ce
Compare
xiaoxiang781216
approved these changes
Jun 20, 2026
acassis
approved these changes
Jun 20, 2026
Contributor
|
@jerpelea please backport to V13 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
Check open access against file mode and owner via fs_checkmode(), verify parent directory permissions on create, and assign creator uid/gid to newly created files.
Impact
fs_checkmode()W_OK | X_OK)CONFIG_FS_PERMISSIONandCONFIG_FS_LITTLEFS_ATTR_UPDATEDepends on
fs_checkmode,fs_checkopenperm)Testing
Tested on ESP32C3,
