build: clean previous compiled files after menuconfig updates#18821
Open
HyphenAlpha456 wants to merge 1 commit intoapache:masterfrom
Open
build: clean previous compiled files after menuconfig updates#18821HyphenAlpha456 wants to merge 1 commit intoapache:masterfrom
HyphenAlpha456 wants to merge 1 commit intoapache:masterfrom
Conversation
github-actions
Bot
added
Area: Build system
Size: XS
xiaoxiang781216
previously approved these changes
Apr 30, 2026
linguini1
requested changes
May 1, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Please follow the PR template :)
Fixes apache#16151. Compares .config state before and after kconfig-mconf and triggers 'make clean' if the configuration was modified to prevent orphaned object files. Signed-off-by: Agnimitra sasaru <158492301+HyphenAlpha456@users.noreply.github.com>
HyphenAlpha456
force-pushed
the
fix/16151-menuconfig-clean
branch
from
b7bd19f to
e8fd9f8
Compare
Author
|
Hi @xiaoxiang781216, I have updated nconfig, qconfig, and gconfig in Unix.mk with the same cmp and rm cleanup logic as requested. Let me know if everything looks good to merge! |
github-actions
Bot
added
Size: S
xiaoxiang781216
approved these changes
May 3, 2026
jerpelea
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a build system bug where orphaned object files are left behind after configuration changes.
.configfile before entering configuration interfaces (menuconfig,nconfig,qconfig,gconfig,xconfig)..configstate upon exit.make cleanto ensure a fresh environment for the next build.Fixes #16151
Impact
make cleanafter tweaking configurations. Prevents hidden linking errors and build corruption.Testing
menuconfigsuccessfully triggers a clean build upon exit.menuconfigwithout saving changes bypasses the clean step, preserving the existing build.