Skip to content

CI: fix labeler for common boards files#18504

Merged
simbit18 merged 1 commit intoapache:masterfrom
raiden00pl:labeler_boards
Mar 8, 2026
Merged

CI: fix labeler for common boards files#18504
simbit18 merged 1 commit intoapache:masterfrom
raiden00pl:labeler_boards

Conversation

@raiden00pl
Copy link
Member

@raiden00pl raiden00pl commented Mar 7, 2026

Summary

CI: fix labeler for common boards files

fix issue from #18500 (comment)

Impact

Fix labeler for common boards files.
Touching these files should trigger the building of all boards

Testing

CI

@raiden00pl raiden00pl requested a review from lupyuen as a code owner March 7, 2026 11:42
@raiden00pl raiden00pl force-pushed the labeler_boards branch 2 times, most recently from 9f03906 to 6702024 Compare March 7, 2026 11:44
@github-actions github-actions bot added Area: CI Size: XS The size of the change in this PR is very small labels Mar 7, 2026
Fix labeler for common boards files.
Touching these files should trigger the building of all boards

Signed-off-by: raiden00pl <raiden00@railab.me>
@acassis
Copy link
Contributor

acassis commented Mar 7, 2026

@raiden00pl something that I realized about seems boards/Kconfig triggering all boards builds, should separated this Kconfig in: Kconfig.arm, Kconfig.riscv, Kconfig.avr, etc. it could avoid builds all boards just because a new board was added to Kconfig or someone changed a specific symbol in a board.

What do you think?

@linguini1
Copy link
Contributor

@raiden00pl something that I realized about seems boards/Kconfig triggering all boards builds, should separated this Kconfig in: Kconfig.arm, Kconfig.riscv, Kconfig.avr, etc. it could avoid builds all boards just because a new board was added to Kconfig or someone changed a specific symbol in a board.

What do you think?

That seems like a smart idea to me! A lot of PRs will modify these big common files when new boards are added. For instance, in #18500 I give the example of #18397. This patch is completely local to the new board implementation, except for modifying board/Kconfig to add the board to the list of supported options. So that would re-trigger the full CI. Your suggestion makes it so we only need to consider a subset of rebuilds, which would be good!

@simbit18 simbit18 merged commit f851e09 into apache:master Mar 8, 2026
88 of 151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants