arch/tricore: add support for tc4xx series chips and boards#18391
arch/tricore: add support for tc4xx series chips and boards#18391jerpelea merged 7 commits intoapache:masterfrom
Conversation
7682822 to
31c2ea0
Compare
745ed4d to
4edecbe
Compare
jerpelea
left a comment
There was a problem hiding this comment.
please document all non Apache license file to
https://github.com/apache/nuttx/blob/master/LICENSE
jerpelea
left a comment
There was a problem hiding this comment.
please add SPDX license identifiers to all files not only Apache licensed ones
4edecbe to
d2a6f48
Compare
ok,thanks, i have updata code |
get it, thanks |
acassis
left a comment
There was a problem hiding this comment.
@zhangyu-duck please update the Documentation https://nuttx.apache.org/docs/latest/platforms/tricore/index.html to include these new chips.
Unfortunately our Documentation is very non-standardized, some Documentation arch are very good, others are very primitive (let say not helpful). So, I suggest you to use https://nuttx.apache.org/docs/latest/platforms/arm/imxrt/index.html as a good reference.
arch/tricore/src/illd/tc4xx/Libraries/doc/iLLD-TC4xx-Releasenotes.pdf
Outdated
Show resolved
Hide resolved
linguini1
left a comment
There was a problem hiding this comment.
I guess since this modifies the TC3xx logic as well, could you please include an OSTest log from a tc3 board? The tc4 log looks good.
|
Also I won't block the PR about this since I have pretty much no familiarity with the tricore architecture, but is it necessary to use the SDK? It seems like this PR needs to include a lot of workarounds for quirks with the SDK (like the libc stubs and patch files). Is it at all possible to avoid using the SDK directly? I know a few other archs in NuttX use this approach (hence why I don't think it's a dealbreaker or anything), but I also know the preferred method is to avoid using vendor SDKs/HALs entirely if possible. |
c080e06 to
f820b57
Compare
boards/tricore/tc397/a2g-tc397-5v-tft/include/board_memorymap.h
Outdated
Show resolved
Hide resolved
|
Hi zhangyu-duck, Great job! My suggestion is to leave the iLLD unchanged and only configure it using the IFX_XXX macros. For your reference, I have already ported NuttX to TC4xN based on iLLD in our internal project, and this port does not modify the iLLD itself. |
Since infineon have open-source plans, I recommend using the ILD library they provide on GitHub. |
f820b57 to
73b4513
Compare
|
Can you please perform a test on a TV3 device as well since both are modified? |
73b4513 to
e9683f3
Compare
ok, i give tc3
i privoid
ofcourse, i will supply it |
add new chip named tc4xx and board tc4evb Signed-off-by: zhangyu117 <zhangyu117@xiaomi.com>
e9683f3 to
26ba829
Compare
|
@linguini1 sorry I did not see your comment |
It's okay, my comment was resolved! |
|
|
||
| config HAVE_SECURITY_CORE | ||
| bool | ||
| --help-- |
There was a problem hiding this comment.
| --help-- | |
| ---help--- |
This is causing NuttX Builds to fail, lemme submit the patch.
https://github.com/lupyuen/nuttx-riscv64/actions/runs/22929878852/job/66548808341#step:5:161
arch/tricore/Kconfig:124: syntax error
arch/tricore/Kconfig:123: unknown option "--help--"
arch/tricore/Kconfig:124:warning: ignoring unsupported character ','
arch/tricore/Kconfig:124: unknown option "In"
|
Patch for Kconfig is here: |
Note: Please adhere to Contributing Guidelines.
Summary
Two main updates:
Impact
support tc4xx chip
Testing
nsh> hello
Hello, World!! tc4 ostest
nsh>
i give tc3 and tc4 ostest.log in attach files
tc4_ostest.log
tc3_ostest.log