boards/boardctl: Add BOARDIOC_NET_GETMAC command #18031
Open
+72
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13627105546
requested review from
gustavonihei,
jerpelea and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: OS Components
jerpelea
previously approved these changes
Jan 20, 2026
13627105546
force-pushed
the
topic/netinit-wifimac
branch
from
e979139 to
e97eee7
Compare
jerpelea
previously approved these changes
Jan 20, 2026
13627105546
force-pushed
the
topic/netinit-wifimac
branch
from
e97eee7 to
2078d72
Compare
13627105546
force-pushed
the
topic/netinit-wifimac
branch
2 times, most recently
from
8d1a92a to
f4cfe96
Compare
xiaoxiang781216
previously approved these changes
Jan 20, 2026
13627105546
force-pushed
the
topic/netinit-wifimac
branch
from
f4cfe96 to
0cd5410
Compare
github-actions
bot
added
the
Area: Documentation
xiaoxiang781216
requested changes
Jan 21, 2026
13627105546
force-pushed
the
topic/netinit-wifimac
branch
2 times, most recently
from
46010d1 to
7bdef73
Compare
13627105546
force-pushed
the
topic/netinit-wifimac
branch
from
7bdef73 to
b140211
Compare
boards/boardctl.c
Outdated
| FAR struct boardioc_macaddr_s *req = | ||
| (FAR struct boardioc_macaddr_s *)arg; | ||
|
|
||
| ret = board_macaddr((FAR const char *)req->ifname, req->macaddr); |
Contributor
There was a problem hiding this comment.
Suggested change
| ret = board_macaddr((FAR const char *)req->ifname, req->macaddr); | |
| ret = board_macaddr(req->ifname, req->macaddr); |
include/sys/boardctl.h
Outdated
| #ifdef CONFIG_BOARDCTL_MACADDR | ||
| struct boardioc_macaddr_s | ||
| { | ||
| uint8_t ifname[IFNAMSIZ]; |
Contributor
There was a problem hiding this comment.
Suggested change
| uint8_t ifname[IFNAMSIZ]; | |
| char ifname[IFNAMSIZ]; |
| struct boardioc_macaddr_s | ||
| { | ||
| uint8_t ifname[IFNAMSIZ]; | ||
| uint8_t macaddr[RADIO_MAX_ADDRLEN]; |
Contributor
There was a problem hiding this comment.
do you need include some header file?
13627105546
force-pushed
the
topic/netinit-wifimac
branch
from
b140211 to
18e8e70
Compare
This commit adds a new boardctl command BOARDIOC_MACADDR to retrieve the MAC address of the network interface. The board_macaddr function needs to be implemented by the board logic. Signed-off-by: daichuan <daichuan@xiaomi.com>
13627105546
force-pushed
the
topic/netinit-wifimac
branch
from
18e8e70 to
4b1f1fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new boardctl command BOARDIOC_NET_GETMAC to retrieve the MAC address of the network interface. The board_get_netmac function needs to be implemented by the board logic.
Note: Please adhere to Contributing Guidelines.
Summary
This PR introduces a new boardctl command BOARDIOC_NET_GETMAC to allow applications (like netinit ) to retrieve the network interface MAC address from the board-specific logic.
Why In some embedded scenarios, the MAC address (especially for Wi-Fi) is stored in board-specific storage (e.g., OTP, NVM, or a config file) and needs to be retrieved by the network initialization logic at runtime. Currently, there is no standard boardctl command for this purpose.
Impact
Testing