cmake:add lib_psa_set/getstackaddr file to CMakeLists.txt#17550
Merged
simbit18 merged 1 commit intoapache:masterfrom Feb 3, 2026
Merged
cmake:add lib_psa_set/getstackaddr file to CMakeLists.txt#17550simbit18 merged 1 commit intoapache:masterfrom
simbit18 merged 1 commit intoapache:masterfrom
Conversation
Contributor
simbit18
reviewed
Dec 17, 2025
2952874 to
0638784
Compare
Contributor
|
@anjiahao1 please rebase the latest master to fix: |
xiaoxiang781216
approved these changes
Dec 20, 2025
Contributor
|
ping @anjiahao1 @xiaoxiang781216 Please rebase to fix the CI issue |
CMake forgot to compile these two files, so add them. Signed-off-by: anjiahao <anjiahao@xiaomi.com>
0638784 to
25853c0
Compare
Contributor
|
For my own understanding, isn't this just swapping the order of the source files? Why does that have an effect? |
xiaoxiang781216
approved these changes
Feb 3, 2026
Contributor
the file name is different. |
simbit18
approved these changes
Feb 3, 2026
linguini1
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMake forgot to compile these two files, so add them.
Impact
nothing,just add file to cmake
Testing
ci build