Skip to content

cmake:add lib_psa_set/getstackaddr file to CMakeLists.txt#17550

Merged
simbit18 merged 1 commit intoapache:masterfrom
anjiahao1:20251217_cmake_stackattr
Feb 3, 2026
Merged

cmake:add lib_psa_set/getstackaddr file to CMakeLists.txt#17550
simbit18 merged 1 commit intoapache:masterfrom
anjiahao1:20251217_cmake_stackattr

Conversation

@anjiahao1
Copy link
Copy Markdown
Contributor

Summary

CMake forgot to compile these two files, so add them.

Impact

nothing,just add file to cmake

Testing

ci build

@github-actions github-actions Bot added Area: OS Components OS Components issues Size: XS The size of the change in this PR is very small labels Dec 17, 2025
@simbit18
Copy link
Copy Markdown
Contributor

simbit18 commented Dec 17, 2025

Comment thread libs/libc/spawn/CMakeLists.txt Outdated
@anjiahao1 anjiahao1 force-pushed the 20251217_cmake_stackattr branch from 2952874 to 0638784 Compare December 18, 2025 02:23
@simbit18
Copy link
Copy Markdown
Contributor

@anjiahao1 please rebase the latest master to fix:
https://github.com/apache/nuttx/actions/runs/20323851306/job/58384997381#step:10:154

====================================================================================
Configuration/Tool: bl602evb/elf
2025-12-18 02:32:54
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
riscv-none-elf-ld: cannot find /github/workspace/sources/nuttx/arch/risc-v/src/crt0.o: No such file or directory
make[4]: *** [Makefile:57: errno] Error 1
make[4]: Target 'install' not remade because of errors.

@acassis
Copy link
Copy Markdown
Contributor

acassis commented Dec 23, 2025

ping @anjiahao1 @xiaoxiang781216

Please rebase to fix the CI issue

CMake forgot to compile these two files, so add them.

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@anjiahao1 anjiahao1 force-pushed the 20251217_cmake_stackattr branch from 0638784 to 25853c0 Compare February 3, 2026 03:22
@linguini1
Copy link
Copy Markdown
Contributor

For my own understanding, isn't this just swapping the order of the source files? Why does that have an effect?

@xiaoxiang781216
Copy link
Copy Markdown
Contributor

For my own understanding, isn't this just swapping the order of the source files? Why does that have an effect?

the file name is different.

@simbit18 simbit18 merged commit 8ecbdf9 into apache:master Feb 3, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: OS Components OS Components issues Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants