NUTCH-3176 URLUtil and urlnormalizer-basic: add support for IDNA2008#914
Open
sebastian-nagel wants to merge 6 commits into
Open
NUTCH-3176 URLUtil and urlnormalizer-basic: add support for IDNA2008#914sebastian-nagel wants to merge 6 commits into
sebastian-nagel wants to merge 6 commits into
Conversation
Contributor
sebastian-nagel
commented
May 12, 2026
sebastian-nagel
commented
- URLUtil:
- make IDNA2008 the default for the methods toASCII and toUNICODE
- provide methods to convert host names both for IDNA2003 and IDNA2008
- urlnormalizer-basic:
- convert host names using IDNA2008 if the property urlnormalizer.basic.host.idna2008 is true
- refactor to share methods between URLUtil and urlnormalizer-basic
- URLUtil:
- make IDNA2008 the default for the methods toASCII and toUNICODE
- provide methods to convert host names both for IDNA2003 and IDNA2008
- urlnormalizer-basic:
- convert host names using IDNA2008 if the property
urlnormalizer.basic.host.idna2008 is true
- refactor to share methods between URLUtil and urlnormalizer-basic
URLUtil: also convert host if not already lowercased
urlnormalizer-basic: properly set direction of conversion (to ASCII or to Unicode) if setConf(conf) is called repeatedly
Extend unit tests.
sebastian-nagel
force-pushed
the
NUTCH-3176-idna2008
branch
from
75fe1f0 to
84699a6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.