NIFI-15953 Improve Proxy Host Header Documentation and Validation#11268
Open
exceptionfactory wants to merge 1 commit into
Open
NIFI-15953 Improve Proxy Host Header Documentation and Validation#11268exceptionfactory wants to merge 1 commit into
exceptionfactory wants to merge 1 commit into
Conversation
64d448a to
11e9287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15953 Updates the Administrator's Guide documentation for the
nifi.web.proxy.hostheader and implements additional validation for proxy host header values based on the configured property.The documentation clarifies the behavior of
Hostheader validation when running with HTTPS enabled, describing TLS Server Name Indication and DNS Subject Alternative Name requirements for server certificates. Property description details also describe expected behavior for reverse proxy servers that provide theX-ProxyHostorX-Forwarded-Hostheader values.The additional Proxy Header Validator follows the same pattern as the Host Port Validator, returning an HTTP 421 Misdirected Request when receiving an invalid host header string.
The implementation and documentation maintain existing requirements that enforce validation when the application is running with HTTPS enabled. Unit test updates exercise the configured Proxy Header Validator and assert expected HTTP response status codes.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation