Skip to content

NIFI-15815 connector details page#11254

Open
scottyaslan wants to merge 3 commits into
apache:mainfrom
scottyaslan:NIFI-15815
Open

NIFI-15815 connector details page#11254
scottyaslan wants to merge 3 commits into
apache:mainfrom
scottyaslan:NIFI-15815

Conversation

@scottyaslan
Copy link
Copy Markdown
Contributor

Summary

NIFI-15815

Screenshot 2026-05-14 at 10 44 03 AM

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@mcgilman mcgilman added the ui Pull requests for work relating to the user interface label May 14, 2026
@mcgilman
Copy link
Copy Markdown
Contributor

Reviewing...

Copy link
Copy Markdown
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clean addition — the split into ConnectorDetail + ConnectorDetailsContent is the right shape, sandbox flags are correctly tightened for a read-only view, and the spec coverage on the visibility branches is thorough.

A few comments below; the only one with real substance is the getFrameSource sanitize-then-bypass pattern, which is duplicated from ConnectorConfigure and worth fixing in both. The rest are small consistency/optional nits.

<div class="flex-1 flex items-center justify-center" data-qa="error-container">
<div class="flex flex-col items-center gap-y-4">
<i class="fa fa-warning error-color text-4xl" data-qa="error-icon" aria-hidden="true"></i>
<div data-qa="error-message">{{ errorMessage }}</div>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor consistency: ConnectorConfigure uses <p class="text-base" data-qa="error-message">{{ errorMessage }}</p> for the same role. Without the <p> + text-base, the error text picks up the surrounding default typography instead of Material body sizing. Suggest:

<p class="text-base" data-qa="error-message">{{ errorMessage }}</p>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly equivalent typogaphically. We do not typically use <p class="text-base"></p> elsewhere in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Pull requests for work relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants