NIFI-15815 connector details page#11254
Conversation
|
Reviewing... |
mcgilman
left a comment
There was a problem hiding this comment.
Nice, clean addition — the split into ConnectorDetail + ConnectorDetailsContent is the right shape, sandbox flags are correctly tightened for a read-only view, and the spec coverage on the visibility branches is thorough.
A few comments below; the only one with real substance is the getFrameSource sanitize-then-bypass pattern, which is duplicated from ConnectorConfigure and worth fixing in both. The rest are small consistency/optional nits.
| <div class="flex-1 flex items-center justify-center" data-qa="error-container"> | ||
| <div class="flex flex-col items-center gap-y-4"> | ||
| <i class="fa fa-warning error-color text-4xl" data-qa="error-icon" aria-hidden="true"></i> | ||
| <div data-qa="error-message">{{ errorMessage }}</div> |
There was a problem hiding this comment.
Minor consistency: ConnectorConfigure uses <p class="text-base" data-qa="error-message">{{ errorMessage }}</p> for the same role. Without the <p> + text-base, the error text picks up the surrounding default typography instead of Material body sizing. Suggest:
<p class="text-base" data-qa="error-message">{{ errorMessage }}</p>There was a problem hiding this comment.
This is exactly equivalent typogaphically. We do not typically use <p class="text-base"></p> elsewhere in the codebase.
There was a problem hiding this comment.
It's used in these places:
1 - https://github.com/apache/nifi/blob/main/nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-configure/connector-configure.component.html#L34
2 - https://github.com/apache/nifi/blob/main/nifi-frontend/src/main/frontend/libs/shared/src/components/connector-wizard/connector-wizard.component.html#L32
3 - https://github.com/apache/nifi/blob/main/nifi-frontend/src/main/frontend/libs/shared/src/components/connector-wizard/connector-wizard.component.html#L115
4 - https://github.com/apache/nifi/blob/main/nifi-frontend/src/main/frontend/libs/shared/src/components/connector-wizard/connector-configuration-step/connector-configuration-step.component.html#L55
Summary
NIFI-15815
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation