NIFI-15880: Allow Connectors to enter a Troublehshooting mode where the flow beco…#11175
NIFI-15880: Allow Connectors to enter a Troublehshooting mode where the flow beco…#11175markap14 wants to merge 1 commit into
Conversation
08ee450 to
2f5bc8f
Compare
| if (!STOPPED_STATES.contains(processor.getScheduledState())) { | ||
| throw new IllegalStateException("Cannot end Troubleshooting mode for " + this + " because Processor " + processor.getIdentifier() | ||
| + " is in state " + processor.getScheduledState() + "; it must be STOPPED or DISABLED."); | ||
| } |
There was a problem hiding this comment.
The way this works currently is a bit confusing. You can enter troubleshooting mode while the processor is running, but you can't end troubleshooting with it still running. This forces the user to have to manually stop all processors before they would be allowed to end troubleshooting. For large connectors, this will be a tedious process of manually stopping everything.
It might be more palatable if STOP was a valid action on the connector as a whole while in troubleshooting mode. But it is explicitly not allowed in the current state.
5d8ef9d to
9a6d871
Compare
…he flow becomes modifiable and user-managed (temporarily) rather than Connector managed.
9a6d871 to
e6b3760
Compare
There was a problem hiding this comment.
ConnectorRepository.getConnectors() got a required ConnectorSyncMode parameter. But FlowController is still calling getConnectors() with no args. Results in a compile error.
…mes modifiable and user-managed (temporarily) rather than Connector managed.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation