NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh#11020
Open
pvillard31 wants to merge 1 commit intoapache:mainfrom
Open
NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh#11020pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31 wants to merge 1 commit intoapache:mainfrom
Conversation
…ntial Refresh Co-authored-by: Lou Vasquez <lou.vasquez@noaa.gov>
9933a74 to
70e63a4
Compare
Contributor
|
Thanks @pvillard31 for the PR. The fix looks fine on a cursory review. Will check it in more detail and run some tests before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh
Fixed
java.lang.IllegalStateException: Connection pool shut downaffecting AWS processors (SQS, S3, etc.) on EKS with pod-level identity. The issue occurs when STS temporary credentials expire and the internal HTTP connection pool used for credential refresh has been garbage collected by the JVM Finalizer thread.The
AWSCredentialsProviderControllerServicecached a singleAwsCredentialsProviderinstance created during@OnEnabled. On EKS, this resolves to aDefaultCredentialsProviderwhose internal chain creates anStsClientwith its ownApacheHttpClientandPoolingHttpClientConnectionManager. The JVM's Finalizer thread can shut down these internal connection pools (confirmed in logs by[Finalizer] Connection manager is shutting downentries). While cached STS credentials remain valid (~1h), requests succeed. Once credentials expire, the STS refresh call fails because its HTTP pool was already shut down.This is a documented AWS SDK V2 behavior: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/troubleshooting.html#faq-connection-pool-shutdown-exception
The prior fix for NIFI-12836 (commit
02cbe199260) changedDefaultCredentialsProvider.create()to.builder().build()to avoid the singleton, but the provider was still cached as a single shared instance in the controller service, leaving it vulnerable to GC finalization of internal SDK objects.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation