NIFI-15716 Added JSON Lines Support to ValidateJson.#11012
Open
dan-s1 wants to merge 6 commits intoapache:mainfrom
Open
NIFI-15716 Added JSON Lines Support to ValidateJson.#11012dan-s1 wants to merge 6 commits intoapache:mainfrom
dan-s1 wants to merge 6 commits intoapache:mainfrom
Conversation
exceptionfactory
requested changes
Mar 17, 2026
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for adding this support in ValidateJson @dan-s1. I think it would be helpful to include the line number in the FlowFile attribute, in answer to your question. I noted a handful of recommended adjustments.
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Outdated
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Outdated
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Outdated
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Outdated
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Outdated
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Outdated
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Show resolved
Hide resolved
...nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java
Show resolved
Hide resolved
dan-s1
force-pushed
the
NIFI-15716
branch
2 times, most recently
from
f907a6d to
62ef295
Compare
exceptionfactory
requested changes
Mar 27, 2026
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @dan-s1, I noted a few more minor recommendations.
Comment on lines
+86
to
+87
| "This Processor supports input containing multiple JSON objects using newline-delimited JSON based on configuration properties, " + | ||
| "otherwise if the input FlowFile contains newline-delimited JSON, only the first line will be validated." |
Contributor
There was a problem hiding this comment.
This is a good opportunity to switch the value to a multi-line string.
| } | ||
|
|
||
| protected static final String ERROR_ATTRIBUTE_KEY = "json.validation.errors"; | ||
| public enum InputFormat implements DescribedValue { |
Contributor
There was a problem hiding this comment.
Suggested change
| public enum InputFormat implements DescribedValue { | |
| enum InputFormat implements DescribedValue { |
| } | ||
| } | ||
|
|
||
| void validateSingleJson(ProcessSession session, FlowFile flowFile) { |
Contributor
There was a problem hiding this comment.
validateFlowFile seems like a better name given the Input Format value.
Suggested change
| void validateSingleJson(ProcessSession session, FlowFile flowFile) { | |
| void validateFlowFile(final ProcessSession session, final FlowFile flowFile) { |
| } | ||
| } | ||
|
|
||
| void validateJsonLines(ProcessSession session, FlowFile flowFile) { |
Contributor
There was a problem hiding this comment.
Suggested change
| void validateJsonLines(ProcessSession session, FlowFile flowFile) { | |
| void validateJsonLines(final ProcessSession session, final FlowFile flowFile) { |
| session.getProvenanceReporter().route(flowFile, REL_VALID); | ||
| session.transfer(flowFile, REL_VALID); | ||
|
|
||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (Exception e) { | |
| } catch (final Exception e) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15716
The following PR introduces support for JSON Lines or NDJSON in the ValidateJson processor. The initial approach is to validate each object and fail fast on the first object which is invalid. The emitted warning message indicates which line has the invalid JSON object. I would like clarification if the line number should also be added to the FlowFile attribute
json.validation.errorsthat is added to hold the validation error messages.In addition to aforementioned feature, Intellij warnings were fixed and in one unit test the use of Jupitor
Arguments.argumentSetreplaced the use ofArguments.argumentsTracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation