NIFI-15254 Add Cassandra Processors into NiFi 2.x Version.#10773
NIFI-15254 Add Cassandra Processors into NiFi 2.x Version.#10773vishal-firgan-ksolves wants to merge 2 commits intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting together this updated version of Cassandra components @vishal-firgan-ksolves.
It is great to have the upgrade to the latest client driver version included.
A recent attempt to reintroduce Cassandra support stalled, but includes some important feedback about additional changes needed. In particular, a number of important implementation conventions need to be addressed before this can be considered for inclusion. I have not reviewed this code in detail, but it looks like most of the following issues mentioned in this comment also need to be addressed in this pull request:
If you are willing to put in the time to work through these issues, then this has the opportunity go forward.
exceptionfactory
left a comment
There was a problem hiding this comment.
Also for the purpose of efficient review, I recommend breaking this pull request into multiple parts. Specifically, starting with only the QueryCassandra Processor would allow us to get the core interface and conventional details addressed. Once that is reviewed and merged, the PutCassandra Processors could be considered. This is not a hard requirement, but it more components will require more review time.
|
Thank you for the feedback @exceptionfactory and for pointing me to the relevant review. I will work through these suggestions and update the code to align with NiFi’s current conventions. I'll let you know once the changes are ready for another look. |
|
@exceptionfactory I’ve pushed a new commit that takes care of all the review and convention updates. Since the processors share a common abstract base class and a few tests are used across multiple processors, splitting the PR right now would likely create duplication and inconsistencies. |
|
Hii @exceptionfactory , I'm just following up to see if you've had a moment to look at the latest commits. I've finished the requested convention updates and addressed the previous feedback. Looking forward to your thoughts when you have a chance! Thanks! |
|
Thanks for the updates @vishal-firgan-ksolves, I will look to review this again soon. |
|
Hi @exceptionfactory |
exceptionfactory
left a comment
There was a problem hiding this comment.
@vishal-firgan-ksolves On a very quick review, I noticed some implementation issues with error handling and logging, along with some dependency management concerns where specific versions are being used instead of inheriting configuration values. There are also a number of structural questions in terms of the abstract classes versus the concrete implementations, and it is not quite clear that all of the previous Processors should remain supported.
With that background, I'm not able to provide the kind of detailed review necessary right now for the volume and variety of components in the current pull request. As mentioned previously, the best possibility for moving this forward would be to reduce the scope significantly. Rather than attempting to add back all of the previous Processors, I recommend selecting one or two as the initial candidates. That would provide the opportunity to reconsider the surface of the of the Controller Service interface and its alignment with the referencing Processors.
Summary
This PR introduces Cassandra processor support for Apache NiFi 2.x, enabling Cassandra integration aligned with the latest DataStax Java driver.
NIFI-15254
Enhancements over NiFi 1.28:
UUID,TIMEUUID,DATE,TIME,TIMESTAMP,DECIMAL,VARINT, etc.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation