Skip to content

Conversation

@szaszm
Copy link
Member

@szaszm szaszm commented Feb 6, 2026

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Signed-off-by: Marton Szasz <szaszm@apache.org>
@szaszm
Copy link
Member Author

szaszm commented Feb 6, 2026

I'm getting zstd and brotli related linker errors locally, but at first I wasn't sure if it's related to the upgrade. After checking the changelog, it seems it probably is, since curl changed some defaults around those compression algorithms. I think their build scripts find the libs on my system, which causes curl to enable them, but they're not available in our build environment. I'll try to link curl to zstd, since we're building that anyway for other extensions, but disable brotli. In the old version, both used to be disabled by default.

@szaszm szaszm changed the title MINIFICPP-2713 upgrade curl to 8.18.0 MINIFICPP-2713 curl: upgrade to 8.18.0, enable zstd Feb 6, 2026
@szaszm szaszm changed the title MINIFICPP-2713 curl: upgrade to 8.18.0, enable zstd MINIFICPP-2713 curl: upgrade to 8.18.0 Feb 9, 2026
@szaszm
Copy link
Member Author

szaszm commented Feb 9, 2026

I gave up on making zstd work and disabled it instead. The linux build works now, but windows has a different curl-related issue:

2026-02-09T13:08:12.5810183Z libcurl.lib(url.c.obj) : error LNK2019: unresolved external symbol __imp_if_nametoindex referenced in function zonefrom_url

I didn't debug this one yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant