Skip to content

MINIFICPP-2707 Catch exceptions during C2 Start/Stop commands #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinzink wants to merge 2 commits into from
Closed

MINIFICPP-2707 Catch exceptions during C2 Start/Stop commands #2093

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5883d73
MINIFICPP-2707 Catch exceptions during C2 Start/Stop commands
martinzink Feb 4, 2026
718fc85
review changes
martinzink Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions libminifi/src/c2/C2Agent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,21 +890,26 @@ void C2Agent::handle_start_stop(const C2ContentResponse& resp) {
});
};

if (lowered_response_name == "flow") {
executeStartStopOnComponent("FlowController");
} else if (lowered_response_name == "processor") {
auto processor_id = resp.getStringArgument("processorId");
if (processor_id) {
executeStartStopOnComponent(processor_id.value());
auto update_state = state::UpdateState::FULLY_APPLIED;
try {
if (lowered_response_name == "flow") {
executeStartStopOnComponent("FlowController");
} else if (lowered_response_name == "processor") {
if (const auto processor_id = resp.getStringArgument("processorId")) {
executeStartStopOnComponent(processor_id.value());
} else {
logger_->log_warn("Processor start/stop request missing 'processorId' argument");
Comment thread
fgerlits marked this conversation as resolved.
}
} else {
logger_->log_warn("Processor start/stop request missing 'processorId' argument");
executeStartStopOnComponent(resp.name);
}
} else {
executeStartStopOnComponent(resp.name);
} catch (const std::exception& err) {
update_state = state::UpdateState::NOT_APPLIED;
logger_->log_warn("Failed to execute StartStopOnComponent command due to \"{}\"", err.what());
}

if (!resp.ident.empty()) {
C2Payload response(Operation::acknowledge, resp.ident, true);
C2Payload response(Operation::acknowledge, update_state, resp.ident, true);
enqueue_c2_response(std::move(response));
}
}
Expand Down
Loading