MINIFICPP-2685 Move MQTT tests to modular docker tests #2091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
added
depends-on-another-PR
low-impact
lordgamez
force-pushed
the
MINIFICPP-2685
branch
from
4927305 to
fb6ed88
Compare
8 tasks
lordgamez
force-pushed
the
MINIFICPP-2683
branch
from
c85588c to
05ba7b1
Compare
lordgamez
force-pushed
the
MINIFICPP-2685
branch
from
fb6ed88 to
590e174
Compare
lordgamez
force-pushed
the
MINIFICPP-2683
branch
from
05ba7b1 to
7037f68
Compare
lordgamez
force-pushed
the
MINIFICPP-2685
branch
from
590e174 to
2a53e51
Compare
fgerlits
reviewed
Feb 11, 2026
| raise RuntimeError(f"Error creating directory '{path}' in container: {output}") | ||
|
|
||
| file_name = str(uuid.uuid4()) | ||
| exit_code, output = self.exec_run(f"sh -c \"printf %s '{content}' > {os.path.join(path, file_name)}\"") |
Contributor
There was a problem hiding this comment.
content may contain quote characters, so it's better to use shlex.quote:
Suggested change
| exit_code, output = self.exec_run(f"sh -c \"printf %s '{content}' > {os.path.join(path, file_name)}\"") | |
| full_path = os.path.join(path, file_name) | |
| pipe_command = f"printf %s {shlex.quote(content)} > {shlex.quote(full_path)}" | |
| exit_code, output = self.exec_run(f"sh -c {shlex.quote(pipe_command)}") |
| context.get_or_create_default_minifi_container().stop() | ||
|
|
||
|
|
||
| @when("\"{container_name}\" flow is stopped") |
Contributor
There was a problem hiding this comment.
nitpicking, but I would add a "the":
Suggested change
| @when("\"{container_name}\" flow is stopped") | |
| @when("the \"{container_name}\" flow is stopped") |
| FROM {base_image} | ||
| RUN echo 'log_dest stderr' >> /mosquitto-no-auth.conf | ||
| CMD ["/usr/sbin/mosquitto", "--verbose", "--config-file", "/mosquitto-no-auth.conf"] | ||
| """.format(base_image='eclipse-mosquitto:2.0.14')) |
Contributor
There was a problem hiding this comment.
we could upgrade this to the latest patch version, 2.0.22, if there are no breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2685
Depends on #2089
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.