Skip to content

unit test bootstrap no securitymanager#9284

Open
ebarboni wants to merge 1 commit intoapache:masterfrom
ebarboni:bootstrapbuild
Open

unit test bootstrap no securitymanager#9284
ebarboni wants to merge 1 commit intoapache:masterfrom
ebarboni:bootstrapbuild

Conversation

@ebarboni
Copy link
Contributor

@ebarboni ebarboni commented Mar 18, 2026

Hi,
unit test were not working using jdk21 as baseline for bootstrap. changing to release on javac target.

So this is a rewrite of the test using ant buildRule,

Most test pass without changing existing assets,

nbm and jnlp use genkey from ant but needs now algo set. I use DSA not sure it's ok.
fixdependencies uses deprecated openide.options

AFAIK
ant bootrap; ant build-platform;ant localtest are needed to get test compile

Comment on lines -111 to -112
assertEquals("Five dependencies: " + s, 5, s.size());
assertEquals(new HashSet<>(Arrays.asList("init", "all-openide.dialogs", "all-openide.util", "all-openide.util.lookup", "all-api.annotations.common")), s);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here dependencies count are not 5 but 2

Comment on lines +1165 to +1166
"dname='CN=A NetBeans Friend, OU=NetBeans, O=netbeans.org, C=US' \n" +
"keyalg='DSA' \n" +
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mandatory change to have ant task executed

Comment on lines 210 to 211
"keyalg='DSA' \n" +
"/>\n" +
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same keyalgo DSA changes

<specification-version>6.2</specification-version>
</run-dependency>
</dependency>
<dependency>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openide.options is removed so it should be pruned

@ebarboni ebarboni added the build label Mar 18, 2026
@mbien
Copy link
Member

mbien commented Mar 18, 2026

unit test were not working using jdk21 as baseline for bootstrap

this indicates that CI isn't running those tests? Should something be added? (tests which don't run don't test anything ;))

@mbien mbien added the tests label Mar 18, 2026
@ebarboni
Copy link
Contributor Author

unit test were not working using jdk21 as baseline for bootstrap

this indicates that CI isn't running those tests? Should something be added? (tests which don't run don't test anything ;))

Would be nice.
A test is KO right now with checklicense where I put System.print

Comment on lines +105 to 108
if (fail != null && "whenpresent".equals(fail.getValue())) {
failMsg = "License found in " + f;
log(failMsg, Project.MSG_ERR);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

construct failMsg anyway, and log it

@ebarboni
Copy link
Contributor Author

@mbien the default build-nozip is in fact minimal. What would be the good place in workflow to have such test running?

@ebarboni ebarboni added this to the NB30 milestone Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants