Added a global preference for user settings.xml for Maven projects#9282
Open
Achal1607 wants to merge 1 commit intoapache:masterfrom
Open
Added a global preference for user settings.xml for Maven projects#9282Achal1607 wants to merge 1 commit intoapache:masterfrom
Achal1607 wants to merge 1 commit intoapache:masterfrom
Conversation
Achal1607
added
Java
Contributor
|
On a cursory look, seems reasonable to me. @sdedic - any comments? Thanks! |
Member
|
useful feature! I found two issues while testing:
|
mbien
added
the
ci:dev-build
mbien
reviewed
Mar 18, 2026
Comment on lines
+1057
to
+1060
| JsonPrimitive newMavenUserSettingsPath = null; | ||
| if (c instanceof JsonPrimitive) { | ||
| newMavenUserSettingsPath = (JsonPrimitive) c; | ||
| } |
Member
There was a problem hiding this comment.
nitpick:
JsonPrimitive newMavenUserSettingsPath = c instanceof JsonPrimitive jp ? jp : null;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new preference in the MavenSettings for custom user
settings.xmlfile.Also, exposed it to the LSP
Below is the screenshot for the new preference Netbeans IDE UI:
Closes #4263