Skip to content

Add support for GlassFish 7.1.0 and GlassFish 8.0.0#9072

Merged
mbien merged 1 commit intoapache:masterfrom
dmainardi:glassfish-8-m14
Mar 7, 2026
Merged

Add support for GlassFish 7.1.0 and GlassFish 8.0.0#9072
mbien merged 1 commit intoapache:masterfrom
dmainardi:glassfish-8-m14

Conversation

@dmainardi
Copy link
Copy Markdown
Contributor

@dmainardi dmainardi commented Dec 8, 2025

Thanks @pepness

NetBeans GlassFish module notes:

Add support for GlassFish 7.1.0
Add support for GlassFish 8.0.0

Release Notes for GlassFish 7
Release Notes for GlassFish 8

@dmainardi dmainardi marked this pull request as draft December 8, 2025 14:42
@dmainardi dmainardi marked this pull request as ready for review December 8, 2025 14:42
@dmainardi dmainardi marked this pull request as draft December 8, 2025 14:44
@dmainardi dmainardi marked this pull request as ready for review December 8, 2025 14:50
@mbien mbien added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 8, 2025
@mbien mbien added this to the NB29 milestone Dec 8, 2025
@apache apache locked and limited conversation to collaborators Dec 8, 2025
@apache apache unlocked this conversation Dec 8, 2025
@mbien mbien requested a review from pepness December 8, 2025 15:46
@dmainardi
Copy link
Copy Markdown
Contributor Author

Even if tests pass Netbeans is not able to start Glassfish 7.1.0. I think it is because of Glassfish's breaking changes made for this release, for example see eclipse-ee4j/glassfish#25553 or eclipse-ee4j/glassfish#25183
I tried to understand the code but I failed, it was the first time with Netbeans and Glassfish code.
I leave the error (and the fixing) to someone else ;-)
Thanks!

Copy link
Copy Markdown
Member

@pepness pepness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new releases from GlassFish (8M14 / 7.1.0) had some breaking changes, when you register the server there is an error and when you try to start the server a different error appear.

Please compile this PR and test it locally to verify that it work on your machine and if it not work like in mine compare the errors.

@mbien mbien removed this from the NB29 milestone Dec 9, 2025
@dmainardi dmainardi requested a review from pepness December 21, 2025 18:31
@dmainardi
Copy link
Copy Markdown
Contributor Author

I updated the code as per your suggestion.
I also changed the code in order to add and start Glassfish after the breaking changes.

@dmainardi dmainardi changed the title Add support for GlassFish 7.1.0, and GlassFish 8.0.0-M14 Add support for GlassFish 7.1.0, and GlassFish 8.0.0-M15 Dec 21, 2025
@lkishalmi lkishalmi added this to the NB29 milestone Jan 29, 2026
@lkishalmi
Copy link
Copy Markdown
Contributor

Shouldn't we consider this one on NB29? Without this one there is no GF server that can run on Java 25.
@ebarboni @neilcsmith-net @mbien

@mbien
Copy link
Copy Markdown
Member

mbien commented Jan 29, 2026

yeah that would make sense. I can squash/rebase/retarget this PR to delivery if its ok with @dmainardi.

@dmainardi
Copy link
Copy Markdown
Contributor Author

For me it is ok. I was just waiting for @pepness approval since this is the first time I contributed to Netbeans code and I do not want to push some "bad code".

@mbien mbien added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jan 30, 2026
@mbien mbien changed the base branch from master to delivery January 30, 2026 18:00
@mbien
Copy link
Copy Markdown
Member

mbien commented Jan 30, 2026

done. branch squashed, rebased and PR targets delivery now. CI will create a dev build for testing.

for the record: we usually only allow fixes during RC phase, but this is mostly about configuration files with low risk for side effects so I believe we can do an exception here. But if other PMC members would be against it i would understand that too - i can rebase it again ;)

would still need a review pass and testing

@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jan 30, 2026
@ebarboni ebarboni changed the base branch from delivery to master February 4, 2026 16:34
@ebarboni ebarboni modified the milestones: NB29, NB30 Feb 4, 2026
@ebarboni
Copy link
Copy Markdown
Contributor

ebarboni commented Feb 4, 2026

still need work and cut for next RC is tomorrow. so back to NB30

@mbien
Copy link
Copy Markdown
Member

mbien commented Feb 5, 2026

I read that GF 8 is now released.

@matthiasblaesing
Copy link
Copy Markdown
Contributor

@dmainardi I looked through the changes and they look sane to me. Please rebase the changes onto current master. Please also check if you think updating to GF 8 would make sense right now. I can understand if you would prefer to just get the current changes in, which is also fine.

Added --module-path and --add-modules in order to start Glassfish after
the bootstrap was redesigned.
@mbien mbien force-pushed the glassfish-8-m14 branch from 2771132 to 89030ad Compare March 6, 2026 23:12
@mbien
Copy link
Copy Markdown
Member

mbien commented Mar 6, 2026

updated to 8.0.0, and jersey 4.0.0 and rebased branch back on top of master. Haven't tested it though.

edit: tested the dev build. Seems to work - will link matching issues

@mbien mbien changed the title Add support for GlassFish 7.1.0, and GlassFish 8.0.0-M15 Add support for GlassFish 7.1.0 and GlassFish 8.0.0 Mar 6, 2026
@mbien mbien linked an issue Mar 7, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@mbien mbien merged commit f02cbe4 into apache:master Mar 7, 2026
30 checks passed
@mbien
Copy link
Copy Markdown
Member

mbien commented Mar 7, 2026

@dmainardi congrats to your first apache contribution (on github) and sorry for the delays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glassfish 8 does not start from local installation

6 participants