Fix inherited versions in BOM consumer POMs - #12710
Open
ulofiai wants to merge 1 commit into
Open
Conversation
Signed-off-by: ulofiai <monsterking@tutamail.com>
gnodet
approved these changes
Aug 8, 2026
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Clean, well-scoped fix that correctly fills in missing dependency versions from imported BOMs in consumer POM generation. The change is narrowly guarded to BUILD_CONSUMER mode only and includes a focused unit test.
Notes:
- The five-predicate guard (
present != null,directDependencies.contains(key),BUILD_CONSUMERrequest type,present.getVersion() == null,dependency.getVersion() != null) ensures this only activates for the exact scenario reported in #12660. - No file overlap with related PR #12641, so no merge conflict risk.
- An end-to-end integration test (similar to PR #12641's
its/core-it-suite/approach) could add extra confidence, but is not blocking.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12660.
When building a consumer model, retain locally declared dependency-management metadata while filling a missing version from an imported BOM. The merge is limited to BUILD_CONSUMER, so regular model import precedence and conflicting BOM imports remain unchanged.
Adds a focused regression test for a versionless managed dependency with an overridden scope.