increase lifecycle bindings priority against pom ones#12334
Open
hboutemy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix goal bindings in
pom.xmlbeing executed before lifecycle bindings forthe
cleanandsitelifecycles (regression vs Maven 3, fixes #12331).Root cause
Lifecycles.plugin()creates executions for built-incleanandsitelifecycle bindings (e.g.
default-clean) without setting a priority, so theydefaulted to
0— the same as user-defined executions frompom.xml.DefaultLifecycleMappingDelegatesorts executions within a phase by priority.When both a lifecycle binding and a pom.xml execution share priority
0,ordering falls back to plugin iteration order. Because
LifecycleBindingsMergerinserts pom.xml plugins before lifecycle-only plugins, pom.xml executions ended
up running first.
For the
defaultlifecycle this was not a problem: packaging bindings (e.g. forjar) are built byDefaultPackagingRegistrywithpriority(i - mojos.size())— always negative — so they already sort before user executions.
Fix
Add
.priority(-1)to thePluginExecutionbuilt inLifecycles.plugin(),making
cleanandsitelifecycle bindings consistent with howdefaultlifecycle packaging bindings work.
Test plan
LifecycleExecutorTest,DefaultLifecyclesTest,BuildPlanCreatorTestall pass (561 tests, 0 failures in
maven-core)mvn cleanwith an antrun executionbound to the
cleanphase now runsdefault-clean(maven-clean-plugin)before the pom.xml antrun execution, matching Maven 3 behavior