-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Eclipse Sisu 1.0.0-SNAPSHOT #11703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eclipse Sisu 1.0.0-SNAPSHOT #11703
Conversation
| <properties> | ||
| <javaVersion>8</javaVersion> | ||
| <version.sisu-maven-plugin>0.9.0.M4</version.sisu-maven-plugin> | ||
| <version.sisu-maven-plugin>0.9.0-SNAPSHOT</version.sisu-maven-plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you mention a 1.0.0(-SNAPSHOT) yesterday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sisu is still on version 0.0.9-SNAPSHOT (https://github.com/eclipse-sisu/sisu-project/blob/93c62c42396addd034b15eb35e289ba167c9bec3/pom.xml#L21), but semantically this is 1.0.0-SNAPSHOT (i.e. next release is 1.0.0 soon).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we have final version https://github.com/eclipse-sisu/sisu-project/releases/tag/releases%2F1.0.0
| <plexusInterpolationVersion>1.29</plexusInterpolationVersion> | ||
| <!-- Blocked by 3.4.0+ changes, see MNG-7710, downgrade from parent 4.0.1 --> | ||
| <version.plexus-utils>3.6.0</version.plexus-utils> | ||
| <guiceVersion>5.1.0</guiceVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cstamas Is Guice 6.0.0 not yet compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guice 6 is compatible, but users could assume we support jakarta inject as well, while Sisu is not. IMHO better like this: be clear about it, plus there is nothing we miss from guice 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite some bugfixes listed in https://github.com/google/guice/wiki/Guice600#guice-core which potentially affect usage in Maven as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see some rationale behind downgrade here #2472
|
Dependabot was faster, closing this out |
To run ITs w/ latest Eclipse Sisu 1.0.0-SNAPSHOT:
https://github.com/eclipse-sisu/sisu-project/milestone/2