basic dir handling in default shader#108
Conversation
|
Because the new PR has no description, I want to quickly describe it: It solves MSHADE-366 in a more fundamental way than both #83 and #104, namely by adding the new feature of handling input directories and input JARs uniformly with regard to service provider minification, instead of simply avoiding to log irritating warnings when directories - most prominently, the own module's It addresses the then open question I raised in #83 (comment), in my MSHADE-366 comment and again in #104 (comment) as a reaction to @rmannibucau's corresponding question, making the warning a non-issue. Therefore, this PR supersedes both of its predecessors. I am suggesting to finish it ASAP (if Romain thinks he still needs to change/improve anything), so we can review and merge it, in order to include it in the hopefully soon to be released Shade 3.3.0. |
|
Sorry, I was a bit too fast with my enthusiasm: In its current state, this PR improves To do:
|
|
@kriegaex updated a bit the PR but think it can be worth importing/adding your test on top of it to harness the code, do you want to do it and adjust the code if needed? |
Follow up of #104 (comment) to share the idea (likely better than discussing).