Skip to content

Fix InterruptedException silently dropping task in SmartExecutor.Limited.submit(Runnable) #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 2 commits into from
Jul 24, 2026
+4 −1
Merged

Fix InterruptedException silently dropping task in SmartExecutor.Limited.submit(Runnable) #2012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19f0543
Fix InterruptedException silently dropping task in SmartExecutor.Limi…
Jul 23, 2026
30255b5
Address review: use RejectedExecutionException, document throws clause
Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion maven-resolver-util/src/main/java/org/eclipse/aether/util/concurrency/SmartExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@
public interface SmartExecutor extends AutoCloseable {
/**
* Submits a {@link Runnable} to execution.
*
* @throws RejectedExecutionException If this executor cannot accept the task.
*/
void submit(Runnable runnable);
void submit(Runnable runnable) throws RejectedExecutionException;

@elharo elharo Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use throws clause for RuntimeExceptions, javadoc comment only


/**
* Submits a {@link Callable} to execution, returns a {@link CompletableFuture}.
Expand Down Expand Up @@ -176,6 +178,7 @@ public void submit(Runnable runnable) {
}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RejectedExecutionException(e);
}
}

Expand Down
Loading