Add any media type to RFC9457 content type header#1894
Merged
slawekjaranowski merged 2 commits intoMay 30, 2026
Conversation
Member
Author
kwin
approved these changes
May 29, 2026
Member
kwin
left a comment
There was a problem hiding this comment.
Just one suggestion, otherwise looks good.
| */ | ||
| public abstract class RFC9457Reporter<T, E extends Exception, R> { | ||
| public static final String CONTENT_TYPE_PROBLEM_DETAILS_JSON = "application/problem+json"; | ||
| public static final String CONTENT_TYPE_PROBLEM_DETAILS_JSON_WITH_ANY = "application/problem+json, */*"; |
Member
There was a problem hiding this comment.
Suggested change
| public static final String CONTENT_TYPE_PROBLEM_DETAILS_JSON_WITH_ANY = "application/problem+json, */*"; | |
| public static final String CONTENT_TYPE_PROBLEM_DETAILS_JSON_AND_ANY = "application/problem+json,*/*"; |
Also no space in CSV!
cstamas
approved these changes
May 29, 2026
Member
|
interesting I didn't know |
olamy
approved these changes
May 29, 2026
Member
|
This is not Jetty but Restlet (ancient 1.1.x), and is set to "strict" mode, which means "do not assume anything else than client states". |
Member
|
Cloudflare needs explicit problem+json (https://blog.cloudflare.com/rfc-9457-agent-error-pages/), other servers probably as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with ASF nexus 2.x