Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Feb 10, 2026

Drastically simplify auth cache, that fixes proxy auth issues.

Fixes #1768

Drastically simplify auth cache, that fixes proxy auth issues.

Fixes apache#1768
@cstamas cstamas added this to the 2.0.15 milestone Feb 10, 2026
@cstamas cstamas self-assigned this Feb 10, 2026
@cstamas cstamas added the bug Something isn't working label Feb 10, 2026
@cstamas cstamas marked this pull request as ready for review February 10, 2026 17:48
@cstamas cstamas changed the title GH-1768 Forward port of fix GH-1768 Drastically simplify auth caching Feb 10, 2026
@kwin
Copy link
Member

kwin commented Feb 10, 2026

Is it possible to add an IT which fails without this fix. Something similar (but simpler) as https://github.com/Eyjafjallajokull-Roman/maven-proxy-auth-repro?

@cstamas
Copy link
Member Author

cstamas commented Feb 10, 2026

I agree about the IT and the need for something in UT as this went unnoticed in current test coverage. OTOH, I am unsure how to set something like that up.

Moreover, if you look at it, the reality is that Resolver does not even have ITs, only UTs. The "demo" codebase was made to run during IT phase only to make sure basic functionality works (as extra next to existing UTs). Resolver was always tested in Maven ITs.

@kwin
Copy link
Member

kwin commented Feb 11, 2026

I cannot properly test, feel free to merge as is. However adding a test to https://github.com/apache/maven-resolver/blob/master/maven-resolver-test-http/src/main/java/org/eclipse/aether/internal/test/util/http/HttpTransporterTest.java leveraging a library like https://github.com/monkeyWie/proxyee (or implement something directly in Jetty) is hopefully feasible later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maven 3.9.x intermittently sends unauthenticated CONNECT to proxy when using multiple artifact threads

2 participants