Conversation
PropertiesMojo sets project properties to artifact file paths. If an artifact has no file (getFile() returns null), the property cannot be meaningfully set and downstream code expecting the property would fail confusingly. Throw MojoExecutionException with a clear diagnostic message instead of NPE.
elharo
changed the title
Contributor
Author
|
Closing - will reopen with a failing test first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertiesMojosets project properties to artifact file paths.artifact.getFile()can returnnullfor unresolved or POM-packaged artifacts.Properties.setProperty()throws NPE on null values, so callingartifact.getFile().getAbsolutePath()with a null file crashes the build with an unhelpful stack trace.fixes #1647
Instead, throw
MojoExecutionExceptionwith a clear diagnostic message at both potential NPE sites:project.getArtifacts()loop (line 118)extraArtifactsresolution path (line 136)