Reorder cases to avoid skipping

[elharo]

No description provided.

[elharo]

This might still be wrong.

[desruisseaux]

We just need to replace if (expected < 1) by if (expected < 0). This is the only correction needed (no need to change order or add another if condition).

[elharo]

The original code looks like this:

        } else if (expected < 1) {
            if (checker instanceof ForkedCompiler) {
                return true; // That implementation actually knows nothing about which options are supported.
            }
            warning = "The '" + option + "' option is not supported.";
        } else if (expected == 0) {
            warning = "The '" + option + "' option does not expect any argument.";
        } 

So if expected == 0 do we still need to check if checker instanceof ForkedCompiler?

[desruisseaux]

So if expected == 0 do we still need to check if checker instanceof ForkedCompiler?

No, ForkedCompiler unconditionally returns -1 because it has no information about which options are supported by external tool.