Skip to content

[MARTIFACT-75] Don't print stack trace from correctly functioning code #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elharo wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[MARTIFACT-75] Don't print stack trace from correctly functioning code #66

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f79bc00
Don't print stack trace from correctly functioning code
elharo Oct 20, 2024
c7956e0
spotless
elharo Oct 20, 2024
8007991
Merge branch 'master' into MARTIFACT-75
elharo Sep 30, 2025
a8e444e
add exception class name
elharo Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReferenceBuildinfoUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import java.util.jar.JarFile;
import java.util.jar.Manifest;
import java.util.zip.ZipEntry;
import java.util.zip.ZipException;

import org.apache.commons.io.IOUtils;
import org.apache.maven.plugin.MojoExecutionException;
Expand Down Expand Up @@ -213,8 +214,10 @@ private ReproducibleEnv extractEnv(File file, Artifact artifact) {
} else {
log.warn("no MANIFEST.MF found in jar " + file);
}
} catch (ZipException e) {
log.warn("Corrupt jar file " + file + "\n" + e.getMessage());
} catch (IOException e) {
log.warn("unable to open jar file " + file, e);
log.warn("unable to read jar file " + file + "\n" + e.getMessage());
Copy link
Copy Markdown
Member

@hboutemy hboutemy Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking again at it: if we do that, we need to display the exception class
like if the exception message was the first line of the stacktrace, as it brings useful info = the type of issue

with that pattern, ok, the rest of the stacktrace can be ignored

Copy link
Copy Markdown
Contributor Author

@elharo elharo Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added exception class name

}
return null;
}
Expand Down