chore(deps-dev): bump ruff to 0.16.1 and prek to 0.4.12 - #1084
Open
potiuk wants to merge 1 commit into
Open
Conversation
Splits the non-breaking half out of apache#1083. That PR grouped three updates; the `mcp` 1.28.1 -> 2.0.0 bump in it is a breaking major that removes `mcp.server.fastmcp` and fails `pytest (oauth-draft)` with `ModuleNotFoundError`. It needs a code migration and gets its own PR. This change carries only the two updates that need no source change. - `ruff` 0.15.21/0.15.22 -> 0.16.1 across all 30 workspace members. - `prek` 0.4.10 -> 0.4.12 at the workspace root. - `mcp` deliberately left at 1.28.1. Ruff 0.16 formats Python inside Markdown fenced blocks, which is why apache#1083 also failed `ruff format` for skill-evals. The ten files it wanted to rewrite are all `evals/**/fixtures/**/report.md` — not one is real source. Those files are test *data*: they simulate what a contributor actually pasted into an issue, single quotes and missing blank lines included, and several are prompt-injection cases whose whole point is that the untrusted text reaches the model verbatim. Reformatting them would silently edit the input the eval grades against, so `tools/skill-evals` excludes the fixture tree from ruff instead. Verified: `ruff format --check` and `ruff check` pass for all 28 applicable members, and `prek run --all-files` exits 0. No fixture file is modified by this commit. Generated-by: Claude Code (Opus 5)
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp1.28.1 → 2.0.0 bump in it is a breaking major that removesmcp.server.fastmcpand failspytest (oauth-draft)withModuleNotFoundError.That half is migrated separately in chore(deps): migrate gmail/oauth-draft to mcp 2.0 #1085.
ruff0.15.21/0.15.22 → 0.16.1 across all 30 workspace members;prek0.4.10 → 0.4.12 at the root.
mcpdeliberately left at 1.28.1.inside Markdown fenced blocks — the reason chore(deps-dev): bump the python-deps group across 9 directories with 3 updates #1083 also failed
ruff formatforskill-evals. The ten files it wanted to rewrite are all
evals/**/fixtures/**/report.md; not one is real source. Those files are testdata: they simulate what a contributor actually pasted into an issue, single
quotes and missing blank lines included, and several are prompt-injection cases
whose whole point is that untrusted text reaches the model verbatim.
Reformatting them would silently edit the input the eval grades against.
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filesexits 0ruff format --checkandruff checkpass for all 28 applicable memberspyproject.tomlfiles anduv.lock— nofixture file is modified by this PR
RFC-AI-0004 compliance
Not applicable — dependency-pin and lint-config change only; no skill or tool
behaviour, no new mutation, no new host access.
Linked issues
Refs #1083
Notes for reviewers
The interesting decision is the
extend-excludeintools/skill-evals/pyproject.tomlrather than accepting the reformat. Worth a look at the two representative diffs
ruff wanted to make:
Both make the fixture less like what a real reporter writes, which is the
opposite of what a fixture is for.
Both this PR and the mcp migration touch
uv.lock, so whichever merges secondneeds a
uv lockre-run. #1083 can be closed once both land.