Reject negative length and offset values in DatagramPacket#696
Open
jmestwa-coder wants to merge 1 commit into
Open
Reject negative length and offset values in DatagramPacket#696jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
Contributor
|
I would like to change the interface in the next ABI version to use The test case would then be unnecessary. Would you like to introduce the interface changes for the next ABI in this PR? |
Contributor
Author
|
Using I'm happy to rework the PR around the interface change if that's the preferred direction. Is there a specific branch or upcoming ABI version where you would like these changes to target? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject negative length and offset values when creating or modifying
DatagramPacketinstances.Changes
DatagramPacketlength and offset arguments.Rationale
DatagramPacketcurrently accepts negative length and offset values and stores them unchanged. This change enforces basic argument invariants at theDatagramPacketboundary and ensures invalid values are rejected before they can propagate through socket operations.Testing
setLength()andsetData()inputs.