Ensure a change to the shared ThreadUtility isActive flag is visible#694
Open
swebb2066 wants to merge 12 commits into
Open
Ensure a change to the shared ThreadUtility isActive flag is visible#694swebb2066 wants to merge 12 commits into
swebb2066 wants to merge 12 commits into
Conversation
rm5248
reviewed
Jun 1, 2026
| void ThreadUtility::addPeriodicTask(const LogString& name, std::function<void()> f, const Period& delay) | ||
| { | ||
| if (!m_priv->log) | ||
| m_priv->log = Logger::getLogger("ThreadUtility"); |
Contributor
There was a problem hiding this comment.
if we're going to add loggers that can go through the normal logging route, we should prefix these loggers with log4cxx. in order to differentiate them from the user-created loggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.