[KYUUBI #7556] Rearm the ZooKeeper engine deregistration watcher after reconnect#7558
Open
Yangxuhao123 wants to merge 1 commit into
Open
[KYUUBI #7556] Rearm the ZooKeeper engine deregistration watcher after reconnect#7558Yangxuhao123 wants to merge 1 commit into
Yangxuhao123 wants to merge 1 commit into
Conversation
Yangxuhao123
force-pushed
the
fix/zk-deregister-watcher-rearm
branch
2 times, most recently
from
0a3eb05 to
33c7223
Compare
Member
|
@Yangxuhao123 rebase on latest master can solve the CI timeout issue. cc @cxzl25 could you please take a look? |
…r after reconnect
Yangxuhao123
force-pushed
the
fix/zk-deregister-watcher-rearm
branch
from
33c7223 to
c9260b5
Compare
cxzl25
reviewed
Jul 14, 2026
| " ZooKeeper. The server will be shut down after the last client session completes.") | ||
| ZookeeperDiscoveryClient.this.deregisterService() | ||
| serviceDiscovery.stopGracefully() | ||
| } else if (event.getType == Watcher.Event.EventType.NodeCreated) { |
Contributor
There was a problem hiding this comment.
What version of zookeeper are you using?
Author
There was a problem hiding this comment.
@cxzl25 zk client is 3.4.14, zk server is 3.8.4, Is this related to zookeeper version change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Closes #7556.
ZooKeeper watches are one-shot. After a Kyuubi engine's ZooKeeper session expires and reconnects, its service node is restored, but the
DeRegisterWatcheris not automatically rearmed. A subsequent node deletion may therefore be missed, preventing graceful shutdown and allowing an unhealthy engine to remain discoverable.This patch rearms the watcher asynchronously after
RECONNECTED, retries when the service node is temporarily unavailable, handles node recreation, and invalidates stale or pending rewatch attempts after a newer reconnect or service deregistration.How was this patch tested?
Added embedded ZooKeeper test coverage for:
RECONNECTEDevent followed by node deletion.The following test suite was executed:
./build/mvn test -pl kyuubi-ha -am \ -Dtest=none \ -DwildcardSuites=org.apache.kyuubi.ha.client.zookeeper.EmbeddedZookeeperDiscoveryClientSuiteAll 16 tests passed.
Was this patch authored or co-authored using generative AI tooling?
Assisted-by: OpenAI Codex (GPT-5)