[Bug] Fix mapping for DECIMAL type to BigDecimal in JdbcColumn#7393
Open
kezhuoquan wants to merge 1 commit intoapache:masterfrom
Open
[Bug] Fix mapping for DECIMAL type to BigDecimal in JdbcColumn#7393kezhuoquan wants to merge 1 commit intoapache:masterfrom
kezhuoquan wants to merge 1 commit intoapache:masterfrom
Conversation
This commit fixes a bug where the DECIMAL type was incorrectly mapped to BigInteger instead of BigDecimal in JdbcColumn, causing type mismatch issues.
Member
|
@kezhuoquan, this seems to be a bug inherited from upstream Hive Side notes: review your AI-generated PR description before sending publicly, such a small change is not worth such a long article to describe. |
Author
So I can only fix this bug in Hive? |
Member
|
@kezhuoquan, we usually follow the upstream-first strategy. I suggest you report and fix this bug in the Hive project first, then port the fix here. |
Author
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
In JDBC/Java, SQL DECIMAL/NUMERIC must map to
java.math.BigDecimalto preserve precision and scale. The current implementation maps DECIMAL tojava.math.BigInteger, which drops fractional parts and causes type mismatches.How was this patch tested?
Existing tests passing indicates no regressions.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Trae AI (GPT-5-high)