feat(string): support IFEQ/IFNE/IFDEQ/IFDNE in SET command#3475
Merged
Conversation
jihuayu
reviewed
May 3, 2026
Member
jihuayu
left a comment
jihuayu
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
The SET command is critical, as 99% of our users rely on it.
We must ensure that its test cases are both comprehensive and accurate.
jihuayu
previously approved these changes
May 6, 2026
git-hulk
reviewed
May 6, 2026
Add IFEQ/IFNE/IFDEQ/IFDNE conditionals to SET command, extending the existing NX/XX/GET subcommand support. Move conditional SET tests into testString to inherit txn-context-enabled matrix, and add non-hex 16-char digest boundary test for IFDEQ/IFDNE.
|
git-hulk
approved these changes
May 6, 2026
jihuayu
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reintroduce conditional options IFEQ / IFNE / IFDEQ / IFDNE for the SET command.
Context
This is a clean, reworked version of the previously closed #3452.
It addresses all previous feedback, reverts the accidental deletion of
CommandDelEX, and is fully rebased onto the latestunstablebranch.All CI checks have been successfully run and verified on my personal fork before submission.
Behavior
WRONGTYPEfor non-string keysSET key value NX GETnow correctly returnsWRONGTYPEfor non-string keys (matching Redis 8.x behavior)Testing
AI-assisted Contribution Disclosure
AI was used for code pattern suggestions, test scaffolding, and debugging assistance.
Core logic, bug fixes, validation, and final implementation were written and verified manually.
@jihuayu PTAL, thanks!