feat(ts): Support IGNORE option when creating TimeSeries#3450
Conversation
jihuayu
left a comment
jihuayu
left a comment
There was a problem hiding this comment.
It looks like this PR will cause backward incompatibility with old data.
We should probably draft a proposal for the storage format changes.
|
Hi @lauk20. If you want to move forward with this PR, please fix the format and lint CI errors. Thanks |
|
| DUPLICATE_POLICY = 1 << 2, | ||
| IGNORE = 1 << 3, | ||
| LABELS = 1 << 4, | ||
| LABELS = 1 << 3, |
There was a problem hiding this comment.
We change the LABELS value. Why we need change it?
You can use comments to indicate that this item is not being used.
| require.ErrorContains(t, rdb.Do(ctx, "ts.add", key, "1000", "13.4").Err(), "update is not supported when DUPLICATE_POLICY is set to BLOCK mode") | ||
| }) | ||
|
|
||
| t.Run("TS.ADD Ignore Option", func(t *testing.T) { |
There was a problem hiding this comment.
The test cases are missing a significant number of negative scenarios where parameters fail to take effect. Could you please add them?
There was a problem hiding this comment.
Thanks for the review. I have added more test scenarios for the IGNORE option. @jihuayu
2 participants
Resolves issue #3215.
AI Usage: AI was used to write the initial draft and tests. Manually reviewed the code logic to verify and fix issues.