Skip to content

feat(rdb): add DUMP support for HyperLogLog type#3371

Open
Zakir032002 wants to merge 3 commits intoapache:unstablefrom
Zakir032002:feature/hyperloglog-dump
Open

feat(rdb): add DUMP support for HyperLogLog type#3371
Zakir032002 wants to merge 3 commits intoapache:unstablefrom
Zakir032002:feature/hyperloglog-dump

Conversation

@Zakir032002
Copy link
Contributor

Summary

Adds DUMP command support for HyperLogLog data type, enabling serialization to Redis-compatible RDB format.

Changes

  • Implemented HyperLogLog encoding in rdb.cc
  • Added test coverage in dump_test.go
  • Validates Redis format compatibility

@Zakir032002
Copy link
Contributor Author

@PragmaTwice , can you validate the approach?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

Copy link
Member

@jihuayu jihuayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal implementation of kvrocks’ HyperLogLog is highly inconsistent with Redis’s; I’d like to see your design decisions.

The data recovered via RESTORE must still support PF commands. Please provide additional test cases to cover this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants