Knox as OIDC Provider#1215
Merged
Merged
Conversation
Test Results27 tests 27 ✅ 3s ⏱️ Results for commit 59c5203. ♻️ This comment has been updated with latest results. |
smolnar82
force-pushed
the
knox_idf_smolnar
branch
4 times, most recently
from
7f07a3f to
2bb7979
Compare
smolnar82
force-pushed
the
knox_idf_smolnar
branch
from
2bb7979 to
8a12ee4
Compare
smolnar82
force-pushed
the
knox_idf_smolnar
branch
from
bd92451 to
c1b243a
Compare
Contributor
Author
|
As part of this PR I modified the Docker-based test orchestration as well, I'll update the Now the tests are completed in 5 mins as opposed to the previous 17-18 mins rounds. Cc. @moresandeep @hanicz (wrt. KNOX-3256) |
moresandeep
reviewed
May 20, 2026
Contributor
moresandeep
left a comment
moresandeep
left a comment
There was a problem hiding this comment.
I am going to post incremental review as I get time :)
Also, it would be great if we can have some comments to help us understand what's going on.
| @Path(AuthorizeResource.RESOURCE_PATH) | ||
| public class AuthorizeResource extends PasscodeTokenResourceBase { | ||
| static final String RESOURCE_PATH = BASE_RESORCE_PATH + "/authorize"; | ||
| private static final UUID KNOX_NAMESPACE = UUID.fromString("6ba7b811-9dad-11d1-80b4-00c04fd430c8"); |
Contributor
There was a problem hiding this comment.
Any reason why this is hardcoded? looks like a seed
|
|
||
| private static final String UTF_8 = StandardCharsets.UTF_8.name(); | ||
| private AuthorizeRequestMetadataStore authorizeRequestMetadataStore; | ||
| private final FederatedOpConfigurationStore federatedOpConfigurationStore = FederatedOpConfigurationStore.getInstance(120000L); |
| params.add(new BasicNameValuePair(CLIENT_ID, opConfig.getClientId())); | ||
| params.add(new BasicNameValuePair(CLIENT_SECRET, opConfig.getClientSecret())); | ||
|
|
||
| try (CloseableHttpClient httpClient = HttpClients.createDefault()) { |
Contributor
There was a problem hiding this comment.
This looks like non-TLS
…'s recent changes
…IDF is present in any topology
… CI/Dev workflows
smolnar82
force-pushed
the
knox_idf_smolnar
branch
from
2ba32fa to
59c5203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Knox becomes an OIDC Provider itself. Until this change it was participating OIDC flows as a Service Provider only through the pac4j federation filter.
This PR is driven by KIP-18.
How was this patch tested?
Manually tested the
Integration Tests
Added Docker-based integration tests that cover the flows described above.
UI changes
The login page has been updated in a way such that it lists all pre-configured federated OPs, if any.