KAFKA-20894: Make StreamsGroupDescription.toString null-safe - #23083
Open
Gimini-3 wants to merge 1 commit into
Open
KAFKA-20894: Make StreamsGroupDescription.toString null-safe#23083Gimini-3 wants to merge 1 commit into
Gimini-3 wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex
Gimini-3
marked this pull request as ready for review
August 5, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-20894
DescribeStreamsGroupsOptionsomits authorized operations by default. The omitted response value is converted tonull, which is a documented valid state forStreamsGroupDescription.authorizedOperations(). However,StreamsGroupDescription.toString()unconditionally calledstream()on that nullable set, so logging or otherwise rendering a successfully described group could throwNullPointerException.This change renders omitted authorized operations as
nullwhile preserving the existing output format for populated sets. It also extends the existing AdminClient test for an omitted authorized-operations response to verify that the resulting description can be converted to a string and includesauthorizedOperations=null.Testing:
DOCKER_API_VERSION=1.40 ./gradlew clients:test./gradlew clients:test --tests org.apache.kafka.clients.admin.KafkaAdminClientTest.testDescribeStreamsGroupsWithAuthorizedOperationsOmitted --tests org.apache.kafka.clients.admin.internals.DescribeStreamsGroupsHandlerTest./gradlew spotlessCheck./gradlew clients:spotbugsMain clients:spotbugsTest -x testThe full clients test suite, targeted regression tests, Checkstyle, SpotBugs main analysis, and Spotless checks passed.
clients:spotbugsTestwas skipped by the build configuration.