KAFKA-20297: Move AbstractIterator, CircularIterator, CloseableIterator... into internal

[m1a2st]

We have exposed several classes in org.apache.kafka.common.utils as
public APIs, which can be misleading since not all classes in this
package are intended for external use.

To clarify API boundaries and prevent unintended usage, we propose
moving the following classes to an internal package:

• AbstractIterator
• CircularIterator
• CloseableIterator
• CopyOnWriteMap
• FixedOrderMap
• PrimitiveRef

Reviewers: Christo lolovc@amazon.com, PoAn Yang payang@apache.org

[nileshkumar3]

Thanks for the PR! A couple of items:

Missed file

TransactionIndex.java still imports org.apache.kafka.common.utils.PrimitiveRef and is not updated by this PR. This will break compilation in the storage module.

Typo: The commit message says "move to interanl"

[clolov]

Missed file
TransactionIndex.java still imports org.apache.kafka.common.utils.PrimitiveRef and is not updated by this PR. This will break compilation in the storage module.

On a quick check, I do not see what you are referring to here. Could you elaborate?

[clolov]

In general this looks good. Is it possible for you to add a bit more information behind this change in the PR description especially given that it doesn't have a JIRA associated with it?

Ah, I was just reviewing another PR linked to KAFKA-20297, I guess that's the one you are targeting?

[m1a2st]

@clolov Thanks for your review. I originally thought this was a minor patch, but I found that there is already a Jira tracking this issue, so I’ve updated the title and description accordingly.

[nileshkumar3]

ransactionIndex.java still imports org.apache.kafka.common.utils.PrimitiveRef and is not updated by this PR. This will break compilation in the storage module.

On a quick check, I do not see what you are referring to here. Could you elaborate?

you're right, my mistake. I double checked , it's not an issue. sorry for the noise.

[chia7712]

@nileshkumar3 the comment seems completely out of context and feels like it was generated by an AI without understanding the actual technical depth of this thread. Out of curiosity, are you a real person, or just using an automated bot?

[nileshkumar3]

@nileshkumar3 the comment seems completely out of context and feels like it was generated by an AI without understanding the actual technical depth of this thread. Out of curiosity, are you a real person, or just using an automated bot?

@chia7712 I am real and this is not out of context. I was on an outdated branch when reviewing this. this file was recently changed. #21577 previously it was using that import.

[mingyen066]

@nileshkumar3 Genuinely curious—how did you find PrimitiveRef import is not updated? Manually checking every renamed file on an outdated branch seems impractical for a human. Did you use some tool/script?

[nileshkumar3]

@nileshkumar3 Genuinely curious—how did you find PrimitiveRef import is not updated? Manually checking every renamed file on an outdated branch seems impractical for a human. Did you use some tool/script?

no tool or script, i just use simple text search in intellij. search for import org.apache.kafka.common.utils.PrimitiveRef or import org.apache.kafka.common.utils./**