JAMES-4171 Allow configure strong distinction between submission and …#2939
Merged
Arsnael merged 1 commit intoapache:masterfrom Feb 10, 2026
Merged
JAMES-4171 Allow configure strong distinction between submission and …#2939Arsnael merged 1 commit intoapache:masterfrom
Arsnael merged 1 commit intoapache:masterfrom
Conversation
quantranhong1999
approved these changes
Feb 10, 2026
Arsnael
approved these changes
Feb 10, 2026
Contributor
Author
|
This work touches a quite critical part of James code: the SMTP server I would have had prefered the pull request to stay opened longer so that it has a chance to collect non-linagorian reviews. As such, if any comments or suggestions arises I'd be happy to carry on follow up work. |
jeantil
reviewed
Feb 13, 2026
| - `true`: act as `strict` | ||
| - `false`: act as `disabled` | ||
|
|
||
| Please note that this parameter only intend to prevent spoofing, and still allow unauthenticated remote users (that do not use local identity) to send email to local users. |
Contributor
There was a problem hiding this comment.
nitpick
Suggested change
| Please note that this parameter only intend to prevent spoofing, and still allow unauthenticated remote users (that do not use local identity) to send email to local users. | |
| Please note that this parameter only intends to prevent spoofing, and still allows unauthenticated remote users (that do not use local identity) to send email to local users. |
| public HookResult doCheck(SMTPSession session, MaybeSender sender) { | ||
| ExtendedSMTPSession nSession = (ExtendedSMTPSession) session; | ||
| if (nSession.verifyIdentity() == SMTPConfiguration.SenderVerificationMode.STRICT) { | ||
| if (!session.isRelayingAllowed() && !nSession.senderVerificationConfiguration().allowUnauthenticatedSender()) { |
Contributor
There was a problem hiding this comment.
In this comment on the corresponding jira it was discussed adding a new defaultly loaded hook instead of changing the behaviour of an existing hook
did you change your mind ?
Contributor
Author
There was a problem hiding this comment.
No I have some local work adapting this that apparently is not shared in the right place.
I will make sure this is adressed timely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mx ports