OAK-12215 Add failover mode configuration in oak-segment-azure#2909
Open
ierandra wants to merge 1 commit into
Open
OAK-12215 Add failover mode configuration in oak-segment-azure#2909ierandra wants to merge 1 commit into
ierandra wants to merge 1 commit into
Conversation
Contributor
|
does this have test coverage? |
Contributor
|
Looking at the proposed code changes, the intent is not to have two storage accounts that will be used simultaneously during the Oak runtime. With that, I do not think the configuration for the second storage account is needed, since Oak only ever connects to one account at activation. The same effect can be achieved by having a deployment layer mount either the primary or the secondary storage account credentials into the existing config fields. Oak doesn't need to know which one it is. Duplicating the credential surface in Configuration adds maintenance cost without enabling new runtime behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAK-12215 Add failover mode configuration in oak-segment-azure