OAK-12054: Refactor creation of ThreadPoolExecutors#2679
Merged
thomasmueller merged 1 commit intoapache:trunkfrom Feb 3, 2026
Merged
OAK-12054: Refactor creation of ThreadPoolExecutors#2679thomasmueller merged 1 commit intoapache:trunkfrom
thomasmueller merged 1 commit intoapache:trunkfrom
Conversation
joerghoh
reviewed
Jan 9, 2026
Contributor
|
@bhabegger good catch, thanks for the PR; can you create a dedicated OAK ticket for it? |
bhabegger
force-pushed
the
fix-executor-service
branch
from
4318b53 to
e61cba0
Compare
Contributor
Author
Well, in fact it was hinted to me by @thomasmueller as a pending task that I took for my onboarding :) So, I don't have much credit for catching this;) |
bhabegger
force-pushed
the
fix-executor-service
branch
from
e61cba0 to
33271ab
Compare
bhabegger
changed the title
bhabegger
force-pushed
the
fix-executor-service
branch
from
33271ab to
eb16e23
Compare
rishabhdaim
requested changes
Jan 14, 2026
bhabegger
force-pushed
the
fix-executor-service
branch
from
eb16e23 to
28c2927
Compare
rishabhdaim
requested changes
Jan 15, 2026
Member
thomasmueller
left a comment
thomasmueller
left a comment
There was a problem hiding this comment.
There is a risk if we change the current behavior, even if the current behavior is not what was intended originally: we could have out-of-memory, concurrency issues etc.
So either the PR should not change the current behavior, or at least, we should have a way to switch back to the old behavior, in case of issues. E.g. with a feature toggle.
Given that we don't currently see issue with the current behavior (other than it's not intended, and can confuse people, etc.), I think we should keep the current behavior.
bhabegger
force-pushed
the
fix-executor-service
branch
3 times, most recently
from
687a16b to
443d867
Compare
bhabegger
force-pushed
the
fix-executor-service
branch
from
5f19daa to
60ee9fa
Compare
rishabhdaim
approved these changes
Jan 16, 2026
rishabhdaim
requested review from
joerghoh,
reschke,
rishabhdaim and
thomasmueller
rishabhdaim
approved these changes
Jan 16, 2026
bhabegger
force-pushed
the
fix-executor-service
branch
from
60ee9fa to
3f44d08
Compare
…e in fact only running one thread)
bhabegger
force-pushed
the
fix-executor-service
branch
from
3f44d08 to
2a6f894
Compare
thomasmueller
approved these changes
Feb 2, 2026
| } | ||
|
|
||
| public static final String REPOSITORY_HOME = "repository.home"; | ||
| private static final int INDEX_COPIER_POOL_SIZE = 5; |
Member
There was a problem hiding this comment.
Nit: if we only use it in one place, it seems not useful to have a constant.
Contributor
Author
There was a problem hiding this comment.
I see 2 benefits though:
- readability by having a name rather than just a number
- having the "setup" of the class at the top (these are potential candidate parameters)
Contributor
Author
There was a problem hiding this comment.
(But I won't fight over it :))
reschke
pushed a commit
that referenced
this pull request
Feb 4, 2026
…e in fact only running one thread) (#2679)
reschke
pushed a commit
that referenced
this pull request
Feb 15, 2026
…e in fact only running one thread) (#2679)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some instantiations of ThreadPoolExecutor were setting a different corePoolSize and maxPoolSize even though they were using an unbounded LinkedBlockingQueue. The pattern was repeated multiple times. This PR attempts to fix and mutualize the ThreadPoolExecutor creation code.