Skip to content

[Load] Preserve pending tablets when parser fails during fallback #18487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Load] Preserve pending tablets when parser fails during fallback #18487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 60 additions & 3 deletions ...tdb/db/storageengine/load/converter/LoadTreeStatementDataTypeConvertExecutionVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.function.Function;
import java.util.stream.Collectors;

import static org.apache.iotdb.db.pipe.resource.memory.PipeMemoryWeightUtil.calculateTabletSizeInBytes;
Expand All @@ -57,6 +58,7 @@ public class LoadTreeStatementDataTypeConvertExecutionVisitor
.getLoadTsFileTabletConversionBatchMemorySizeInBytes();

private final StatementExecutor statementExecutor;
private final Function<File, LoadTreeTsFileTabletIterator> tabletIteratorFactory;

@FunctionalInterface
public interface StatementExecutor {
Expand All @@ -65,7 +67,14 @@ public interface StatementExecutor {

public LoadTreeStatementDataTypeConvertExecutionVisitor(
final StatementExecutor statementExecutor) {
this(statementExecutor, file -> new LoadTreeTsFileTabletIterator(file, true));
}

LoadTreeStatementDataTypeConvertExecutionVisitor(
final StatementExecutor statementExecutor,
final Function<File, LoadTreeTsFileTabletIterator> tabletIteratorFactory) {
this.statementExecutor = statementExecutor;
this.tabletIteratorFactory = tabletIteratorFactory;
}

@Override
Expand All @@ -87,11 +96,24 @@ public Optional<TSStatus> visitLoadFile(
boolean shouldReleaseContext = !isManagedTask;

try {
if (conversionContext.deferredStatus != null) {
final TSStatus result =
flushPendingTablets(conversionContext, loadTsFileStatement.isConvertOnTypeMismatch());
if (!handleTSStatus(result, loadTsFileStatement)) {
shouldReleaseContext = !isManagedTask || !isTemporaryUnavailable(result);
return Optional.of(result);
}
final TSStatus deferredStatus = conversionContext.deferredStatus;
conversionContext.deferredStatus = null;
shouldReleaseContext = true;
return Optional.of(deferredStatus);
}

final List<File> files = loadTsFileStatement.getTsFiles();
while (conversionContext.fileIndex < files.size()) {
if (conversionContext.tabletIterator == null) {
conversionContext.tabletIterator =
new LoadTreeTsFileTabletIterator(files.get(conversionContext.fileIndex), true);
tabletIteratorFactory.apply(files.get(conversionContext.fileIndex));
}

if (conversionContext.deferredTabletRawReq != null) {
Expand Down Expand Up @@ -164,11 +186,29 @@ public Optional<TSStatus> visitLoadFile(
.STORAGE_LOG_FAILED_TO_CONVERT_DATA_TYPE_FOR_LOADTSFILESTATEMENT_5D132E57,
loadTsFileStatement,
e);
final boolean retryable = isRetryableConversionException(e);
final TSStatus status =
loadTsFileStatement.accept(
LoadTsFileDataTypeConverter.TREE_STATEMENT_EXCEPTION_VISITOR, e);
shouldReleaseContext =
!isManagedTask || !LoadTsFileDataTypeConverter.isMemoryPressureException(e);

// A parser can fail after producing tablets that are still waiting for the next batch
// boundary. Submit those tablets before reporting the parser error so the error does not
// discard successfully converted data.
if (!retryable && !conversionContext.tabletRawReqs.isEmpty()) {
final TSStatus flushStatus =
flushPendingTablets(conversionContext, loadTsFileStatement.isConvertOnTypeMismatch());
if (!handleTSStatus(flushStatus, loadTsFileStatement)) {
if (isManagedTask && isTemporaryUnavailable(flushStatus)) {
conversionContext.deferredStatus = status;
shouldReleaseContext = false;
} else {
shouldReleaseContext = true;
}
return Optional.of(flushStatus);
}
}

shouldReleaseContext = !isManagedTask || !retryable;
return Optional.of(status);
} finally {
if (shouldReleaseContext) {
Expand Down Expand Up @@ -201,6 +241,21 @@ private static boolean isTemporaryUnavailable(final TSStatus status) {
== TSStatusCode.PIPE_RECEIVER_TEMPORARY_UNAVAILABLE_EXCEPTION.getStatusCode());
}

private static boolean isRetryableConversionException(final Throwable throwable) {
if (LoadTsFileDataTypeConverter.isMemoryPressureException(throwable)) {
return true;
}

Throwable current = throwable;
while (current != null) {
if (current instanceof InterruptedException) {
return true;
}
current = current.getCause();
}
return false;
}

private static void deleteSourceFiles(final LoadTsFileStatement statement) {
statement
.getTsFiles()
Expand Down Expand Up @@ -228,6 +283,7 @@ private static final class TreeConversionContext implements AutoCloseable {
private Pair<Tablet, Boolean> deferredTabletWithIsAligned;
private PipeTransferTabletRawReq deferredTabletRawReq;
private long deferredTabletRawReqSize;
private TSStatus deferredStatus;

private void addTablet(final PipeTransferTabletRawReq request, final long size) {
tabletRawReqs.add(request);
Expand Down Expand Up @@ -259,6 +315,7 @@ public void close() {
deferredTabletWithIsAligned = null;
deferredTabletRawReq = null;
deferredTabletRawReqSize = 0;
deferredStatus = null;
block.close();
}
}
Expand Down
59 changes: 59 additions & 0 deletions ...db/storageengine/load/converter/LoadTreeStatementDataTypeConvertExecutionVisitorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.apache.tsfile.file.metadata.enums.TSEncoding;
import org.apache.tsfile.read.TsFileSequenceReader;
import org.apache.tsfile.read.common.Path;
import org.apache.tsfile.utils.Pair;
import org.apache.tsfile.write.TsFileWriter;
import org.apache.tsfile.write.record.Tablet;
import org.apache.tsfile.write.schema.IMeasurementSchema;
Expand Down Expand Up @@ -113,6 +114,32 @@ public void testFallbackToQueryForRemainingDevicesWhenScanParserHitsCorruption()
Assert.assertEquals(loadedPointCountBeforeCorruption, loadedPointCountAfterFallback);
}

@Test
public void testFlushesPendingTabletsWhenIteratorFails() throws Exception {
tsFile = File.createTempFile("load-tree-pending-tablet", ".tsfile");
final List<IMeasurementSchema> schemaList =
Arrays.asList(new MeasurementSchema("s0", TSDataType.INT64, TSEncoding.PLAIN));
final Tablet tablet = new Tablet(DEVICE_0, schemaList, 1);
tablet.addTimestamp(0, 1);
tablet.addValue("s0", 0, 1L);

final Map<String, Integer> pointCountByDevice = new HashMap<>();
final LoadTreeStatementDataTypeConvertExecutionVisitor visitor =
new LoadTreeStatementDataTypeConvertExecutionVisitor(
statement -> {
collectLoadedPoints(statement, pointCountByDevice);
return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
},
file -> new ThrowingTabletIterator(file, tablet));

final Optional<TSStatus> status =
visitor.visitLoadFile(LoadTsFileStatement.createUnchecked(tsFile.getAbsolutePath()), null);

Assert.assertTrue(status.isPresent());
Assert.assertEquals(TSStatusCode.LOAD_FILE_ERROR.getStatusCode(), status.get().getCode());
Assert.assertEquals(1, pointCountByDevice.getOrDefault(DEVICE_0, 0).intValue());
}

@Test
public void testLoadScanParserUsesQueryMemoryPoolInsteadOfPipeMemory() throws Exception {
tsFile = new File("load-tree-parser-query-memory.tsfile");
Expand Down Expand Up @@ -421,4 +448,36 @@ private static void setPipeMemoryManagementEnabled(final boolean enabled) {
CommonDescriptor.getInstance().getConfig().setPipeMemoryManagementEnabled(enabled);
}
}

private static class ThrowingTabletIterator extends LoadTreeTsFileTabletIterator {
private final Pair<Tablet, Boolean> tabletWithIsAligned;
private boolean tabletAvailable = true;

private ThrowingTabletIterator(final File file, final Tablet tablet) {
super(file, true);
tabletWithIsAligned = new Pair<>(tablet, false);
}

@Override
public boolean hasNext() {
if (tabletAvailable) {
return true;
}
throw new IllegalStateException("synthetic parser failure");
}

@Override
public Pair<Tablet, Boolean> next() {
if (!tabletAvailable) {
throw new IllegalStateException("synthetic parser failure");
}
tabletAvailable = false;
return tabletWithIsAligned;
}

@Override
public void close() {
// No parser resources are allocated by this test iterator.
}
}
}
Loading