Fix stale field cache handling in table last-row optimization#17677
Open
Caideyipi wants to merge 6 commits into
Open
Fix stale field cache handling in table last-row optimization#17677Caideyipi wants to merge 6 commits into
Caideyipi wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17677 +/- ##
============================================
- Coverage 40.42% 40.31% -0.11%
Complexity 2574 2574
============================================
Files 5179 5179
Lines 349230 349281 +51
Branches 44675 44688 +13
============================================
- Hits 141177 140826 -351
- Misses 208053 208455 +402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
May 15, 2026
|
jt2594838
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes an incorrect cache-hit case in table last-row optimization.
When a cached field value is
EMPTY_PRIMITIVE_TYPE, the cache may only know the latest row time while the field-levelcache is stale. Reusing that entry can return incorrect
last_by(..., time)results.This PR treats that state as a cache miss and falls back to scan, prioritizing correctness over an unsafe cache hit.
Test
Adds a regression case in
IoTDBMultiTAGsWithAttributesTableIT#lastCacheTestto reproduce the stale-cache scenario ona single DataNode.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR